Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73172

Auto-completion COMPLETION_COMPLETE_PASS status can not enhance in custom theme

    XMLWordPrintable

Details

    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • MDL-73172-master
    • Hide

      Before testing

      • Download the test patch file MDL-73172-patch-file.patch to your moodle instance's root folder.
      • Apply it: "git apply MDL-73172-patch-file.patch"
        This is just a hack so that the standard theme displays 'PASS' when in the complete-pass state. This simulates what you might do in a custom theme in order to display this state differently.

      As an administrator, manager or teacher:

      1. Create a quiz in a course
      2. Give it a name.
      3. Expand "Completion tracking" and ensure the following settings:
        Require view: Tick on the check box "Student must view this activity to complete it"
      4. Click "Save and display"
      5. Click "Edit quiz"
      6. Add a simple question (e.g. true/false).

      As a student in that course:

      1. Click the name of the quiz
      2. Click "Attempt quiz now"
      3. Do the quiz
      4. Click "Finish attempt"

      Expected result:

      Students must see a green Done: View badge.*

      As an administrator, manager or teacher:

      1. Create a quiz in a course
      2. Give it a name.
      3. Expand "Completion tracking" and ensure the following settings:
        Require view: Tick on the check box "Student must view this activity to complete it"
        Require grade: Tick on the check box "Student must receive a grade to complete" this activity
      4. Expand "Grade" and set "Grade to pass" to a suitable low value e.g. 1
      5. Click "Save and display"
      6. Click "Edit quiz"
      7. Add a simple question (e.g. true/false).

      As a student in that course:

      1. Click the name of the quiz
      2. Click "Attempt quiz now"
      3. Do the quiz, answering the question correctly so that you achieve the pass grade
      4. Click "Finish attempt"

      Expected result:

      Students must see a green Done: View badge.
      Students must see PASS.

      After test

      Make sure to reset: git reset --hard origin/master

      Show
      Before testing Download the test patch file MDL-73172-patch-file.patch to your moodle instance's root folder. Apply it: " git apply MDL-73172 -patch-file.patch " This is just a hack so that the standard theme displays 'PASS' when in the complete-pass state. This simulates what you might do in a custom theme in order to display this state differently. As an administrator, manager or teacher: Create a quiz in a course Give it a name. Expand "Completion tracking" and ensure the following settings: Require view: Tick on the check box "Student must view this activity to complete it" Click "Save and display" Click "Edit quiz" Add a simple question (e.g. true/false). As a student in that course: Click the name of the quiz Click "Attempt quiz now" Do the quiz Click "Finish attempt" Expected result: Students must see a green Done: View badge.* As an administrator, manager or teacher: Create a quiz in a course Give it a name. Expand "Completion tracking" and ensure the following settings: Require view: Tick on the check box "Student must view this activity to complete it" Require grade: Tick on the check box "Student must receive a grade to complete" this activity Expand "Grade" and set "Grade to pass" to a suitable low value e.g. 1 Click "Save and display" Click "Edit quiz" Add a simple question (e.g. true/false). As a student in that course: Click the name of the quiz Click "Attempt quiz now" Do the quiz, answering the question correctly so that you achieve the pass grade Click "Finish attempt" Expected result: Students must see a green Done: View badge. Students must see PASS. After test Make sure to reset: git reset --hard origin/master

    Description

      In MDL-70817 moodle merge COMPLETION_COMPLETE and COMPLETION_COMPLETE_PASS into one status complete. It makes it impossible to maintain the behaviour of COMPLETION_COMPLETE_PASS in custom themes.

      My suggestion is to add a new additional $detail->statuscompletepass which can be used by renderer/template. This is not used by core themes but may be needed in custom themes.

      Attachments

        1. image-2021-12-03-17-25-05-537.png
          image-2021-12-03-17-25-05-537.png
          40 kB
        2. image-2021-12-03-17-25-40-286.png
          image-2021-12-03-17-25-40-286.png
          12 kB
        3. image-2021-12-03-17-29-49-928.png
          image-2021-12-03-17-29-49-928.png
          12 kB
        4. MDL-73172-patch-file.patch
          0.7 kB
        5. Screenshot 1.PNG
          Screenshot 1.PNG
          14 kB
        6. Screenshot 2.PNG
          Screenshot 2.PNG
          14 kB

        Issue Links

          Activity

            People

              dinhhien0307 DinhPhamVinhHien
              dinhhien0307 DinhPhamVinhHien
              Sam Marshall Sam Marshall
              Jun Pataleta Jun Pataleta
              Gladys Basiana Gladys Basiana
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                28/Nov/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h