Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73172

Auto-completion COMPLETION_COMPLETE_PASS status can not enhance in custom theme

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MDL-73172-master
    • Hide

      Before testing

      • Apply the attached patch file MDL-73172-patch-file.patch

      This is just a hack so that the standard theme displays 'PASS' when in the complete-pass state. This simulates what you might do in a custom theme in order to display this state differently.

      As an administrator, manager or teacher:

      1. Create a quiz in a course
      2. Give it a name.
      3. Expand "Completion tracking" and ensure the following settings:
        Require view: Tick on the check box "Student must view this activity to complete it"
      4. Click "Save and display"
      5. Click "Edit quiz"
      6. Add a simple question (e.g. true/false).

      As a student in that course:

      1. Click the name of the quiz
      2. Click "Attempt quiz now"
      3. Do the quiz
      4. Click "Finish attempt"

      Expected result:

      Students must see a green Done: View badge.*

      As an administrator, manager or teacher:

      1. Create a quiz in a course
      2. Give it a name.
      3. Expand "Completion tracking" and ensure the following settings:
        Require view: Tick on the check box "Student must view this activity to complete it"
        Require grade: Tick on the check box "Student must receive a grade to complete" this activity
      4. Expand "Grade" and set "Grade to pass" to a suitable low value e.g. 1
      5. Click "Save and display"
      6. Click "Edit quiz"
      7. Add a simple question (e.g. true/false).

      As a student in that course:

      1. Click the name of the quiz
      2. Click "Attempt quiz now"
      3. Do the quiz, answering the question correctly so that you achieve the pass grade
      4. Click "Finish attempt"

      Expected result:

      Students must see a green Done: View badge.
      Students must see PASS.

      Show
      Before testing Apply the attached patch file MDL-73172 -patch-file.patch This is just a hack so that the standard theme displays 'PASS' when in the complete-pass state. This simulates what you might do in a custom theme in order to display this state differently. As an administrator, manager or teacher: Create a quiz in a course Give it a name. Expand "Completion tracking" and ensure the following settings: Require view: Tick on the check box "Student must view this activity to complete it" Click "Save and display" Click "Edit quiz" Add a simple question (e.g. true/false). As a student in that course: Click the name of the quiz Click "Attempt quiz now" Do the quiz Click "Finish attempt" Expected result: Students must see a green Done: View badge.* As an administrator, manager or teacher: Create a quiz in a course Give it a name. Expand "Completion tracking" and ensure the following settings: Require view: Tick on the check box "Student must view this activity to complete it" Require grade: Tick on the check box "Student must receive a grade to complete" this activity Expand "Grade" and set "Grade to pass" to a suitable low value e.g. 1 Click "Save and display" Click "Edit quiz" Add a simple question (e.g. true/false). As a student in that course: Click the name of the quiz Click "Attempt quiz now" Do the quiz, answering the question correctly so that you achieve the pass grade Click "Finish attempt" Expected result: Students must see a green Done: View badge. Students must see PASS.

    Description

      In MDL-70817 moodle merge COMPLETION_COMPLETE and COMPLETION_COMPLETE_PASS into one status complete. It makes it impossible to maintain the behaviour of COMPLETION_COMPLETE_PASS in custom themes.

      My suggestion is to add a new additional $detail->statuscompletepass which can be used by renderer/template. This is not used by core themes but may be needed in custom themes.

      Attachments

        Activity

          People

            dinhhien0307 DinhPhamVinhHien
            dinhhien0307 DinhPhamVinhHien
            Sam Marshall Sam Marshall
            Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated: