Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73173

Confusing 'Content' region.

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0
    • 4.0
    • General, Themes
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • wip_MDL-73173_master
    • Hide

      n/a

      Show
      n/a
    • Hide
      Turn on developer mode
      1. If using MDK, run "mdk run mindev"
      2. Alternatively:
        1. Turn on developer-level debugging - 'debug' setting.
        2. Set 'allowthemechangeonurl' so that you can change themes via the URL.
      Test
      1. Navigate to the 'My courses' page using the relevant item on Boost's navbar.
      2. Confirm that the 'My courses' page displays with the 'Course overview' block showing.
      3. On the URL, append '?theme=classic' and press 'Enter' to reload the page with the 'Classic' theme.
      4. Confirm that the 'My courses' page displays with the 'Course overview' block showing.
      Show
      Turn on developer mode If using MDK, run " mdk run mindev " Alternatively: Turn on developer-level debugging - 'debug' setting. Set 'allowthemechangeonurl' so that you can change themes via the URL. Test Navigate to the 'My courses' page using the relevant item on Boost's navbar. Confirm that the 'My courses' page displays with the 'Course overview' block showing. On the URL, append '?theme=classic' and press 'Enter' to reload the page with the 'Classic' theme. Confirm that the 'My courses' page displays with the 'Course overview' block showing.

    Description

      Original issue:

      MDL-70801 adds the 'mycourses' layout to the Boost and Classic themes, it also defines in their 'config.php' a region called 'content', however this is not implemented!  Also, Boost defines the language file 'region-content' string, but Classic does not.

      Therefore as the 'mycourses' page does not require block regions then 'content' needs removing!  i.e. with an empty 'regions' array in config.php for 'mycourses' just like 'login'.

      UPDATE:

      Found the line:

       

      echo $OUTPUT->custom_block_region('content');

       

      in '/my/courses.php'.  Strange there is no '$PAGE->blocks->add_region('content');' line as with other files using this method.  So... to avoid confusion with theme developers, then perhaps that is a better solution and not have 'content' listed as a block region in the theme's config.php file.

       

      Attachments

        1. MDL-73173_Boost.png
          79 kB
          Angelia Dela Cruz
        2. MDL-73173_Classic.png
          105 kB
          Angelia Dela Cruz

        Issue Links

          Activity

            People

              gb2048 Gareth J Barnard
              gb2048 Gareth J Barnard
              Mathew May Mathew May
              Jun Pataleta Jun Pataleta
              Angelia Dela Cruz Angelia Dela Cruz
              Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h