Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73184

Allow pagesize to be changed in custom report outputs

    XMLWordPrintable

Details

    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_401_STABLE
    • Hide

      Setup

      1. Login as admin
      2. Navigate to Users > Accounts > Upload users in site administration
      3. Upload MDL-73184_users.csvto create test users

      Custom pagesize for custom reports (no regressions)

      1. Navigate to Reports > Report builder > Custom reports in site administration
      2. Press New report
      3. Create a new report from the Users report source
      4. Press 'Close' in the top-right corner to return to the 'Custom reports' page
      5. Press 'View report' action for the previously created report
      6. Confirm 30 rows are displayed
      7. Press 'Show all XX' link below the table
      8. Confirm 'Show 30 per page' link is shown below the table
      9. Press 'Show 30 per page' link
      10. Confirm 30 rows are displayed

      Custom pagesize for system reports (no regressions)

      1. Ensure cron has run at least once on your site to ensure the log is populated
      2. Navigate to Server > Task logs in site administration
      3. Confirm 30 rows are displayed
      4. Press 'Show all XX' link below the table
      5. Confirm 'Show 30 per page' link is shown below the table
      6. Press 'Show 30 per page' link
      7. Confirm 30 rows are displayed

      Apply code patch to test new feature

      1. Apply MDL-73184-test.patch to the code.
        • This patch sets the custom reports pagesize to 5
        • This patch sets the 'Task logs' system report pagesize to 5

      Custom pagesize for custom reports with the patch

      1. Navigate to Reports > Report builder > Custom reports in site administration
      2. Press New report
      3. Create a new report from the Users report source
      4. Press 'Close' in the top-right corner to return to the 'Custom reports' page
      5. Press 'View report' action for the previously created report
      6. Confirm only 5 rows are displayed
      7. Confirm table sorting works correctly
      8. Confirm table pagination works correctly
      9. Press 'Show all XX' link below the table
      10. Confirm 'Show 5 per page' link is shown below the table
      11. Press 'Show 5 per page' link
      12. Confirm only 5 rows are displayed

      Custom pagesize for system reports with the patch

      1. Navigate to Server > Task logs in site administration
      2. Confirm only 5 rows are displayed
      3. Confirm table sorting works correctly
      4. Confirm table pagination works correctly
      5. Press 'Show all XX' link below the table
      6. Confirm 'Show 5 per page' link is shown below the table
      7. Press 'Show 5 per page' link
      8. Confirm only 5 rows are displayed
      Show
      Setup Login as admin Navigate to Users > Accounts > Upload users in site administration Upload MDL-73184_users.csv to create test users Custom pagesize for custom reports (no regressions) Navigate to Reports > Report builder > Custom reports in site administration Press New report Create a new report from the Users report source Press 'Close' in the top-right corner to return to the 'Custom reports' page Press 'View report' action for the previously created report Confirm 30 rows are displayed Press 'Show all XX' link below the table Confirm 'Show 30 per page' link is shown below the table Press 'Show 30 per page' link Confirm 30 rows are displayed Custom pagesize for system reports (no regressions) Ensure cron has run at least once on your site to ensure the log is populated Navigate to Server > Task logs in site administration Confirm 30 rows are displayed Press 'Show all XX' link below the table Confirm 'Show 30 per page' link is shown below the table Press 'Show 30 per page' link Confirm 30 rows are displayed Apply code patch to test new feature Apply  MDL-73184-test.patch  to the code. This patch sets the custom reports pagesize to 5 This patch sets the 'Task logs' system report pagesize to 5 Custom pagesize for custom reports with the patch Navigate to Reports > Report builder > Custom reports in site administration Press New report Create a new report from the Users report source Press 'Close' in the top-right corner to return to the 'Custom reports' page Press 'View report' action for the previously created report Confirm only 5 rows are displayed Confirm table sorting works correctly Confirm table pagination works correctly Press 'Show all XX' link below the table Confirm 'Show 5 per page' link is shown below the table Press 'Show 5 per page' link Confirm only 5 rows are displayed Custom pagesize for system reports with the patch Navigate to Server > Task logs in site administration Confirm only 5 rows are displayed Confirm table sorting works correctly Confirm table pagination works correctly Press 'Show all XX' link below the table Confirm 'Show 5 per page' link is shown below the table Press 'Show 5 per page' link Confirm only 5 rows are displayed

    Description

      We should be able to change the page size of a custom report, making it display more or less rows as required.

      Attachments

        1. mdl-73184.gif
          mdl-73184.gif
          3.86 MB
        2. MDL-73184-test.patch
          1 kB
        3. MDL-73184_users.csv
          6 kB
        4. MDL-73184_custom reports with patch.webm
          756 kB
        5. MDL-73184_custom reports.webm
          955 kB
        6. MDL-73184_system reports with patch.webm
          1.37 MB
        7. MDL-73184_system reports.webm
          1.68 MB

        Activity

          People

            mikelmartíncorrales Mikel Martín Corrales
            alexmorris Alexander Morris
            Paul Holden Paul Holden
            Jun Pataleta Jun Pataleta
            Angelia Dela Cruz Angelia Dela Cruz
            David Matamoros, Mikel Martín Corrales, Paul Holden
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              14/Nov/22

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 10 minutes
                5h 10m