Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
4.0, 4.1
-
MOODLE_400_STABLE, MOODLE_401_STABLE
-
MOODLE_401_STABLE
-
Hide
Setup
- Login as admin
- Navigate to Users > Accounts > Upload users in site administration
- Upload MDL-73184_users.csv
to create test users
Custom pagesize for custom reports (no regressions)
- Navigate to Reports > Report builder > Custom reports in site administration
- Press New report
- Create a new report from the Users report source
- Press 'Close' in the top-right corner to return to the 'Custom reports' page
- Press 'View report' action for the previously created report
- Confirm 30 rows are displayed
- Press 'Show all XX' link below the table
- Confirm 'Show 30 per page' link is shown below the table
- Press 'Show 30 per page' link
- Confirm 30 rows are displayed
Custom pagesize for system reports (no regressions)
- Ensure cron has run at least once on your site to ensure the log is populated
- Navigate to Server > Task logs in site administration
- Confirm 30 rows are displayed
- Press 'Show all XX' link below the table
- Confirm 'Show 30 per page' link is shown below the table
- Press 'Show 30 per page' link
- Confirm 30 rows are displayed
Apply code patch to test new feature
- Apply MDL-73184-test.patch
to the code.
- This patch sets the custom reports pagesize to 5
- This patch sets the 'Task logs' system report pagesize to 5
Custom pagesize for custom reports with the patch
- Navigate to Reports > Report builder > Custom reports in site administration
- Press New report
- Create a new report from the Users report source
- Press 'Close' in the top-right corner to return to the 'Custom reports' page
- Press 'View report' action for the previously created report
- Confirm only 5 rows are displayed
- Confirm table sorting works correctly
- Confirm table pagination works correctly
- Press 'Show all XX' link below the table
- Confirm 'Show 5 per page' link is shown below the table
- Press 'Show 5 per page' link
- Confirm only 5 rows are displayed
Custom pagesize for system reports with the patch
- Navigate to Server > Task logs in site administration
- Confirm only 5 rows are displayed
- Confirm table sorting works correctly
- Confirm table pagination works correctly
- Press 'Show all XX' link below the table
- Confirm 'Show 5 per page' link is shown below the table
- Press 'Show 5 per page' link
- Confirm only 5 rows are displayed
ShowSetup Login as admin Navigate to Users > Accounts > Upload users in site administration Upload MDL-73184_users.csv to create test users Custom pagesize for custom reports (no regressions) Navigate to Reports > Report builder > Custom reports in site administration Press New report Create a new report from the Users report source Press 'Close' in the top-right corner to return to the 'Custom reports' page Press 'View report' action for the previously created report Confirm 30 rows are displayed Press 'Show all XX' link below the table Confirm 'Show 30 per page' link is shown below the table Press 'Show 30 per page' link Confirm 30 rows are displayed Custom pagesize for system reports (no regressions) Ensure cron has run at least once on your site to ensure the log is populated Navigate to Server > Task logs in site administration Confirm 30 rows are displayed Press 'Show all XX' link below the table Confirm 'Show 30 per page' link is shown below the table Press 'Show 30 per page' link Confirm 30 rows are displayed Apply code patch to test new feature Apply MDL-73184-test.patch to the code. This patch sets the custom reports pagesize to 5 This patch sets the 'Task logs' system report pagesize to 5 Custom pagesize for custom reports with the patch Navigate to Reports > Report builder > Custom reports in site administration Press New report Create a new report from the Users report source Press 'Close' in the top-right corner to return to the 'Custom reports' page Press 'View report' action for the previously created report Confirm only 5 rows are displayed Confirm table sorting works correctly Confirm table pagination works correctly Press 'Show all XX' link below the table Confirm 'Show 5 per page' link is shown below the table Press 'Show 5 per page' link Confirm only 5 rows are displayed Custom pagesize for system reports with the patch Navigate to Server > Task logs in site administration Confirm only 5 rows are displayed Confirm table sorting works correctly Confirm table pagination works correctly Press 'Show all XX' link below the table Confirm 'Show 5 per page' link is shown below the table Press 'Show 5 per page' link Confirm only 5 rows are displayed
Description
We should be able to change the page size of a custom report, making it display more or less rows as required.