Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73217

Edit switch scroll currently edited element

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • 4.0, 4.1.1, 4.1.2
    • Course, Usability
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • master_MDL-73217
    • Hide
      • Ensure theme boost is selected in Site administration > Appearance > Theme selector
      • Navigate to Site administration > Developement > Make test course
      • Select size of course M (2 minutes), complete informations and click Create course 
      • Navigate to created course (Just click continue)
      • Scroll page to an activity
      • Click on edit mode switch
      • Ensure page scrolls to where we were (specifically the activity we were seeing/looking at)
      • Ensure when we stop in between two course modules that it scrolls to first one
      • Ensure that module is highlighted in blue in left course index drawer
      • Navigate to course parameters
      • Retry the above when changing course format, specifically for a single activity course, and informal
      • Change theme and open inspector ensuring no error exists
      Show
      Ensure theme boost is selected in Site administration > Appearance > Theme selector Navigate to Site administration > Developement > Make test course Select size of course M (2 minutes), complete informations and click Create course  Navigate to created course (Just click continue) Scroll page to an activity Click on edit mode switch Ensure page scrolls to where we were (specifically the activity we were seeing/looking at) Ensure when we stop in between two course modules that it scrolls to first one Ensure that module is highlighted in blue in left course index drawer Navigate to course parameters Retry the above when changing course format, specifically for a single activity course, and informal Change theme and open inspector ensuring no error exists

    Description

      When the users toggle the Edit mode (on or off) via the new switch in Moodle 4.0, it would be interesting if, instead of going back to the top of the page, they were automatically scrolled down where they were before toggling the switch.

      save_scroll_pos seems to have been deprecated since 4.2 there is a small typo in question/qengine, another tracker will be opened for that.

      Also there seems to be a race condition between another library (or browser itself) with this feature on smaller screen, hence deletion of overflow properties in theme/boost/amd/src/drawers.js (see isSmall method)

      I have also classified methods in scroll manager by alphabetical order.

      Attachments

        Issue Links

          Activity

            People

              marcalexandreghaly Marc-Alexandre GHALY
              levemar Marie-Eve Lévesque
              Laurent David Laurent David
              Votes:
              34 Vote for this issue
              Watchers:
              42 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 minutes
                  6m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.