Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73222

"Add a block" modal duplicated, can add block to wrong region

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0
    • 4.0
    • Blocks, Navigation
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to Dashboard
      3. Enable Edit mode
      4. Click Add a block in the centre content region
      5. Confirm Add a block modal only loads once
        • e.g. when you close the "Add a block" modal, there's not another "Add a block" modal underneath it.
      6. Press Cancel
      7. Click Add a block in the right block region
      8. Add a Text block
      9. Confirm new Text block is added to right block region
      Show
      Log in as admin Navigate to Dashboard Enable Edit mode Click Add a block in the centre content region Confirm Add a block modal only loads once e.g. when you close the " Add a block " modal, there's not another " Add a block " modal underneath it. Press Cancel Click Add a block in the right block region Add a Text block Confirm new Text block is added to right block region

    Description

      Small thing from MDL-70197

      When on user dashboard in editing mode, clicking either of the Add a block links:

      1. Opens the Add a block modal twice (because it's listeners were registered twice);
      2. Closing both the modals, and clicking on the other Add a block link on the page will add the block to the wrong region (because the modal is "remembered")

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Mathew May Mathew May
              Jun Pataleta Jun Pataleta
              Gladys Basiana Gladys Basiana
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 45 minutes
                  1h 45m