Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73274

Add block/activity inconsistent

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-73274-master
    • Hide

      Test the add a block button

      1. Login as admin
      2. Navigate to your dashboard
      3. Switch edit mode on
      4. Verify you see the add a block button in both the page content and the blocks drawer
      5. Add a block in the page content
      6. Verify your block is added to the page content
      7. Add a block in the blocks drawer
      8. Verify your block is added to the page drawer
      9. Verify the design of the add a block button is similar to the design in the description of this issue

      Test the Add activity or resource

      1. Navigate to a course page
      2. Switch edit mode on
      3. Verify you see the "Add activity or resource" button
      4. Verify the text is underlined when hovering the button
      Show
      Test the add a block button Login as admin Navigate to your dashboard Switch edit mode on Verify you see the add a block button in both the page content and the blocks drawer Add a block in the page content Verify your block is added to the page content Add a block in the blocks drawer Verify your block is added to the page drawer Verify the design of the add a block button is similar to the design in the description of this issue Test the Add activity or resource Navigate to a course page Switch edit mode on Verify you see the "Add activity or resource" button Verify the text is underlined when hovering the button

    Description

      The "Add a block" link is not consistent with the "Add an activity or resource" link:

      1. Block has an underline on hover, Activity does not
      2. The + icon used are the inverse of each other
      3. Padding is vastly different
      4. Add a block is not positioned in the middle

       

      (EDIT to add rafaellechugo's proposal to description)

      Changes to implement on "Add an activity or resourde" link:

      • the roundness of the box around the "plus" icon should be defined by its correspondent bootstrap theme variables
      • the box around the "plus" icon should have the same colour as the icon and the link (it looks clearer now)
      • the gap between the box containing the plus icon and the text should be the same as the container padding (1rem or 16px)
      • when hovering the container background gets slightly darker
      • when hovering the container the text gets underlined

      Changes to implement on "Add block" link:

      • Move the plus icon to the left (however I don't think it should be printed inside a box, like its bigger counterpart)
      • they both use the same icon now
      • they both use the same padding now
      • when hovering the container background gets slightly darker
      • when hovering the container the text gets underlined
      • It should not be printed inside a white "block"
      • It should be printed against the page background and have the same width as the blocks

      Attachments

        Issue Links

          Activity

            People

              basbrands Bas Brands
              dobedobedoh Andrew Lyons
              Mathew May Mathew May
              Jun Pataleta Jun Pataleta
              Angelia Dela Cruz Angelia Dela Cruz
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 30 minutes
                  5h 30m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.