Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73294

Add flag to column to exclude it from downloads

    XMLWordPrintable

Details

    • Improvement
    • Status: Development in progress
    • Minor
    • Resolution: Unresolved
    • 4.0
    • None
    • Report builder
    • MOODLE_400_STABLE
    • MDL-73294-master_excludecolumn
    • Hide

      This requires a developer to test.

      Patch not applied:

      System report:

      1. Login to your Moodle test site
      2. Visit the config changes report (/report/configlog/index.php)
      3. Download the report using the button at the bottom of the page
      4. Observe that the Date column is included in the download

      Custom report:

      1. Login to your Moodle test site
      2. Visit the custom reports page (/reportbuilder/index.php)
      3. Create a new report using the 'Users' report source
      4. Visit the custom reports page (/reportbuilder/index.php)
      5. Click the 'View report' button on your new report
      6. Download the report using the button at the bottom of the page
      7. Observe that the 'Full name' column is included in the download

      Patch applied:

      System report:

      1. For the purposes of testing that it's functional, change this line https://github.com/moodle/moodle/blob/master/report/configlog/classes/local/entities/config_change.php#L92 to be `->set_is_downloadable(true)`
      2. Login to your Moodle test site
      3. Visit the config changes report (/report/configlog/index.php)
      4. Download the report using the button at the bottom of the page
      5. Observe that the Date column is not included in the download

      Custom report:

      1. For the purposes of testing that it's functional, change this line https://github.com/moodle/moodle/blob/master/reportbuilder/classes/local/entities/user.php#L126 to be `->set_is_downloadable(true)`
      2. Login to your Moodle test site
      3. Visit the custom reports page (/reportbuilder/index.php)
      4. Create a new report using the 'Users' report source
      5. Visit the custom reports page (/reportbuilder/index.php)
      6. Click the 'View report' button on your new report
      7. Download the report using the button at the bottom of the page
      8. Observe that the 'Full name' column is not included in the download
      Show
      This requires a developer to test. Patch not applied: System report: Login to your Moodle test site Visit the config changes report (/report/configlog/index.php) Download the report using the button at the bottom of the page Observe that the Date column is included in the download Custom report: Login to your Moodle test site Visit the custom reports page (/reportbuilder/index.php) Create a new report using the 'Users' report source Visit the custom reports page (/reportbuilder/index.php) Click the 'View report' button on your new report Download the report using the button at the bottom of the page Observe that the 'Full name' column is included in the download Patch applied: System report: For the purposes of testing that it's functional, change this line https://github.com/moodle/moodle/blob/master/report/configlog/classes/local/entities/config_change.php#L92 to be `->set_is_downloadable(true)` Login to your Moodle test site Visit the config changes report (/report/configlog/index.php) Download the report using the button at the bottom of the page Observe that the Date column is not included in the download Custom report: For the purposes of testing that it's functional, change this line https://github.com/moodle/moodle/blob/master/reportbuilder/classes/local/entities/user.php#L126 to be `->set_is_downloadable(true)` Login to your Moodle test site Visit the custom reports page (/reportbuilder/index.php) Create a new report using the 'Users' report source Visit the custom reports page (/reportbuilder/index.php) Click the 'View report' button on your new report Download the report using the button at the bottom of the page Observe that the 'Full name' column is not included in the download

    Description

      Columns should have a flag that allows them to be excluded from being in a report download, this is for use cases such as MDL-72831 where you wouldn't want the select column to be included in the download.

      Attachments

        Issue Links

          Activity

            People

              alexmorris Alexander Morris
              alexmorris Alexander Morris
              Paul Holden Paul Holden
              David Matamoros, Mikel Martín Corrales, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 30 minutes
                  2h 30m