[MDL-73318] Component Library JS eval uses innerHTML, should use innerText - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
https://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-73318~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/5ee0b620ae...MDL-73318-master
Testing Instructions:
Hide

Build the component library

grunt componentlibrary

Navigate to Site adminsitration -> Development -> UI Component library

Look through the Moodle -> Javascript pages

Confirm that they all work

Apply the attached patch:

git am 0001-MDL-73318-DO-NOT-COMMIT.patch

Rebuild the component library

grunt componentlibrary

Navigate to the Moodle -> Javascript -> Emojipicker page

Confirm that it still works

Confirm that there are no errors shown in the JS console
Show
Build the component library grunt componentlibrary Navigate to Site adminsitration -> Development -> UI Component library Look through the Moodle -> Javascript pages Confirm that they all work Apply the attached patch: git am 0001-MDL-73318-DO-NOT-COMMIT.patch Rebuild the component library grunt componentlibrary Navigate to the Moodle -> Javascript -> Emojipicker page Confirm that it still works Confirm that there are no errors shown in the JS console

The innerHTML contains escaped values, i.e. => becomes => which makes it impossible to write example JS using ES6.

We should use innerText instead.

blocks

MDL-73314 Add CL documentation for core/toast

documents

MDL-72544 Set default style of toast notifications as "info"

Participants:: Andrew Lyons, Angelia Dela Cruz, Bas Brands, CiBoT, Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

1h 35m