Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73335

Quiz and question bank tertiary navigation followup

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-73335-tim
    • Hide

      Prerequisites to test

      1. Create a course.
      2. Enrol a teacher and student.
      3. Add an quiz activity.
      4. Add a true-false question to the quiz, so it can be attempted.

      Quiz

      Test quiz with time limit.

      1. Login as a teacher, Edit the quiz settings so that the quiz has a time-limit.
      2. Log in as Student, and navigate to the quiz.
      3. Click 'Start attempt'
      4. Verify that the warning that the quiz has a time limit opens in an in-page modal.

      Test quiz for the enforced delay setting

      1. Login as a teacher, edit the settings for the quiz, and set an enforced delay between 1st and 2nd attempts of 1 minute and an enforced delay between later attempts of 30 seconds. Add a question to complete the quiz.
      2. Login as a student and attempt the quiz.
      3. Go back to the Quiz.
      4. You should not see "Re-attempt quiz" button until the time delay between attempts has passed. You should also see a text notifying the user:
        "You must wait before you may re-attempt this quiz. You will be allowed to start another attempt after" followed by date and time.
      5. In the tertiary nav, you should not see button: "Attempt quiz".

      Test for dropdown selection in the question bank - the order is preserved

      1. Login as a teacher and navigate to the question bank tab located in the quiz activity.
      2. The default option in the dropdown is "Questions".
      3. When selected any of the items the order should not change in the menu. That is the order should be "Questions", "Categories", "Import" and "Export" same.

      Test for import/export validation in question bank

      1. Login as a teacher and navigate to the question bank tab via the quiz activity.
      2. Select the "Import" from the dropdown selection.
      3. Click on the "Import" button at the bottom of the page. The validation error should be seen as red text. For example: "You must supply a value" in "File format" section or "Required" in "Import questions from file" section.
      4. The dropdown selection should still point to "Import.
      5. Repeat the same procedure in step 2 by selecting "Export".
      6. Click on "Export questions to file" button at the bottom of the page.
      7. The validation error "You must supply a value here" would be seen in the "File format" section. Apart from that the dropdown selection should still point to "Export".

      Test for cog icon in the Quiz tab

      1. Login as a teacher and navigate to the Quiz tab of the quiz activity.
      2. The cog icon should not be seen.

      Test for user/group overrides tab

      1. Login as a teacher. and navigate to Overrides tab in the quiz activity.{}
      2. When "User overrides" dropdown is selected, "User overrides" heading should be shown under the tertiary nav menu.
      3. When "Group overrides" dropdown is selected "Group overrides" heading should be shown under the tertiary nav.

      Test for access messages for quiz

      1. Login as teacher and modify the settings of the quiz
        a. Add "Grade to pass" as "5.00"
        b. Enable "Time limit" and set to 1 minute.
      2. The access messags shown in the Quiz tab should be shown after the tertiary nav.

       

      Show
      Prerequisites to test Create a course. Enrol a teacher and student. Add an quiz activity. Add a true-false question to the quiz, so it can be attempted. Quiz Test quiz with time limit. Login as a teacher, Edit the quiz settings so that the quiz has a time-limit. Log in as Student, and navigate to the quiz. Click 'Start attempt' Verify that the warning that the quiz has a time limit opens in an in-page modal. Test quiz for the enforced delay setting Login as a teacher, edit the settings for the quiz, and set an enforced delay between 1st and 2nd attempts of 1 minute and an enforced delay between later attempts of 30 seconds. Add a question to complete the quiz. Login as a student and attempt the quiz. Go back to the Quiz. You should not see "Re-attempt quiz" button until the time delay between attempts has passed. You should also see a text notifying the user: " You must wait before you may re-attempt this quiz. You will be allowed to start another attempt after " followed by date and time. In the tertiary nav, you should not see button: "Attempt quiz". Test for dropdown selection in the question bank - the order is preserved Login as a teacher and navigate to the question bank tab located in the quiz activity. The default option in the dropdown is "Questions". When selected any of the items the order should not change in the menu. That is the order should be "Questions", "Categories", "Import" and "Export" same. Test for import/export validation in question bank Login as a teacher and navigate to the question bank tab via the quiz activity. Select the "Import" from the dropdown selection. Click on the "Import" button at the bottom of the page. The validation error should be seen as red text. For example: "You must supply a value" in "File format" section or "Required" in "Import questions from file" section. The dropdown selection should still point to "Import. Repeat the same procedure in step 2 by selecting "Export". Click on "Export questions to file" button at the bottom of the page. The validation error "You must supply a value here" would be seen in the "File format" section. Apart from that the dropdown selection should still point to "Export". Test for cog icon in the Quiz tab Login as a teacher and navigate to the Quiz tab of the quiz activity. The cog icon should not be seen. Test for user/group overrides tab Login as a teacher. and navigate to Overrides tab in the quiz activity. { } When "User overrides" dropdown is selected, "User overrides" heading should be shown under the tertiary nav menu. When "Group overrides" dropdown is selected "Group overrides" heading should be shown under the tertiary nav. Test for access messages for quiz Login as teacher and modify the settings of the quiz a. Add "Grade to pass" as "5.00" b. Enable "Time limit" and set to 1 minute. The access messags shown in the Quiz tab s hould be shown after the tertiary nav.  
    • 3
    • Navigation push 10, Navigation push 11, Navigation push 13, Navigation push 14

    Description

      Given the following designs on figma we need to implement the tertiary navigation for the Quiz module and Question Bank:

      Teacher view: https://www.figma.com/proto/gHd0sjZCeq2Dog2pGugldo/Navigation?page-id=7078%3A38473&node-id=7078%3A40062&viewport=-350%2C2380%2C0.25&scaling=scale-down&hotspot-hints=0

      Student view: https://www.figma.com/proto/gHd0sjZCeq2Dog2pGugldo/Navigation?page-id=1253%3A4212&node-id=6763%3A2859&viewport=-995%2C-3777%2C0.5&scaling=scale-down

      Some of this work was done in MDL-71915, but it was agreed to revert all commits related to Quiz and Question bank and reintroduce the code separated in logical commits.

      This is a list of the issues/regressions that needs to be addressed and included to the general tertiary navigation changes:

      1. The dropdown selection does not get preserved when a validation error happens. To reproduce:
        1. As a teacher, go to the Question bank.
        2. Select Export
        3. Press "Export questions to file" without selecting a File format
        4. Validation fails
        5. Expected: The dropdown will show "Export" as selected.
        6. Actual: The dropdown selects the first item on the list (Questions) instead of the "Export" menu item.
        7. This behavior is also noticed with import. For instance in step 2 select "Import" and then in the following page, click "Import" button at the bottom. You would see validation fails and user sees "Question" instead of "Import" in the menu item.
      2. Students are presented with the option to re-attempt the quiz regardless of the enforced delay between attempts (Identified in MDLQA-15546, MDL-73323).
        1. Login as a teacher, edit the settings for the quiz and set an enforced delay between 1st and 2nd attempts of 1 minute and an enforced delay between later attempts of 30 seconds.
        2. Login as a student and attempt the quiz.
        3. Go back to the Quiz.
        4. Expected: you should not have an option to re-attempt the quiz until the time delay between attempts has passed. There should be a text notifying the user that he must wait until can re-attempt the quiz
        5. Actual: there is an option to 'attempt quiz' which triggers an error.
      3. And, more generally, the button to start/continue a quiz attempt/preview should have an appropriate button lable at all times. That is, initially the button is 'Attempt quiz', but if you leave in the middle of a quiz attempt, and come back later, it will say 'Continue the last attempt', etc. Basically, the logic that was there before was right, and should not have been changed.
      4. The access message for the quiz is shown at the bottom, instead it should be shown after the tertiary nav.
      5. Update the heading text to "User overrides"/"Group overrides" in the user/group override pages and move it under the tertiary navigation.
      6. Move the 'Add category' section (Question bank > Categories) to its own page and add a button (primary) "Add category" in the Question bank > Categories tertiary navigation which
      7. redirects to this page.
      8. Remove the cog icon from the quiz activity.
      9. When the quiz has a time limit, there needs to be some spacing between that and any other information such as the grading method. We should either display these paragraphs in separate lines as the original behavior or display them on the same line with some responsive spacing. Also, we should move them just below the tertiary navigation buttons.
      10. The 'Edit quiz' button should be removed from the tertiary navigation and new item 'Questions' (linking to this page) should be added to the secondary navigation instead.
      11. The 'Attempt quiz' button should be 'primary' for students. NOTE: I wasn't able to replicate this on the QA site, but it would be good to double check whether there are any existing scenarios where this button is displayed as secondary.
      12. The default visible items in the secondary navigation should be organized in the following order: Quiz,  Settings, Questions, Results, Question bank.
      13. The secondary navigation item 'Overrides' should  be renamed to 'Settings overrides' and placed in the secondary more menu by default.
      14. When a student starts an attempt in a quiz with a set time limit, a modal should be displayed notifying the student about the time limit restrictions as in 3.11.
      15. As a student, in the quiz summary page the 'Submit all and finish' button should be primary
      16. The review quiz page should be max-width.

      Attachments

        Issue Links

          Activity

            People

              timhunt Tim Hunt
              Geshoski Mihail Geshoski
              Mihail Geshoski Mihail Geshoski
              Ilya Tregubov Ilya Tregubov
              Angelia Dela Cruz Angelia Dela Cruz
              Votes:
              3 Vote for this issue
              Watchers:
              15 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 5 hours, 27 minutes
                  3d 5h 27m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.