Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73349

Review privacy/classes/tests classes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.9.11, 3.10.8, 3.11.4, 4.0, 4.1
    • Privacy, Unit tests
    • None
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE

      Detected while working on MDL-73348

      There are a few files under privacy/classes/tests:

      • provider_testcase.php
      • requests
        • approved_contextlist.php
        • content_writer.php
      1. "tests" is a wrong level2 namespace (it should be "test" - API name)
      2. "provider_testcase.php" should be somewhere under privacy/tests maybe fixtures.

      I imagine that those files were put there originally because of, that way, being autoloaded, because they are extensively used by all the provider / privacy testcases in Moodle.

      So, surely, it's tricky to move them out from autoloaded space and we'll have to wait for autoloading to work under "tests/" directories to get them moved.

      So, just registering the found problem here. I've been searching for some issue in the Tracker about the "tests/" autoloading, but haven't found any, so far.

            Unassigned Unassigned
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.