[MDL-73391] Unit test failure in master branch undefined function external_generate_token_for_current_user - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 4.0
Component/s: Libraries
Labels:
- ci

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
https://github.com/danmarsden/moodle.git
Pull Main Branch:
~~MDL-73391~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...danmarsden:MDL-73391
Testing Instructions:

Hide

Initialise phpunit:

php admin/tool/phpunit/cli/init.php

immediately after, run core_notifications_testcase tests and make sure no errors are reported.

$ vendor/bin/phpunit --testsuite=core_login_testsuite --filter core_login_notifications_testcase

Show
Initialise phpunit: php admin/tool/phpunit/cli/init.php immediately after, run core_notifications_testcase tests and make sure no errors are reported. $ vendor/bin/phpunit --testsuite=core_login_testsuite --filter core_login_notifications_testcase

Description

We're seeing these in our CI for Moodle 4.0

1) core_login_notifications_testcase::test_mobile_app_login_notificationError: Call to undefined function external_generate_token_for_current_user()
/var/www/html/login/tests/notifications_test.php:158/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
2) core_login_notifications_testcase::test_mobile_app_login_notification_skip_same_ipError: Call to undefined function external_generate_token_for_current_user()
/var/www/html/login/tests/notifications_test.php:207/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
3) core_login_notifications_testcase::test_mobile_app_login_notification_skip_same_deviceError: Call to undefined function external_generate_token_for_current_user()
/var/www/html/login/tests/notifications_test.php:254/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
ERRORS!

I suspect it's reproduceable by doing an init call and then running the test immediately after - probably similar to WP-2774 (we run our tests in suites here)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-73391_testing.png
66 kB
23/Dec/21 10:23 AM

Issue Links

is a regression caused by

MDL-66776 Send notifications when new devices are used to log in into the site

Closed

Activity

People

Assignee:: Dan Marsden

Reporter:: Dan Marsden

Peer reviewer:: Paul Holden

Integrator:: Victor Déniz Falcón

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, Dan Marsden, Paul Holden, Victor Déniz Falcón

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 16/Dec/21 9:32 AM

Updated:: 23/Dec/21 11:59 PM

Resolved:: 23/Dec/21 11:59 PM

Fix Release Date:: 19/Apr/22

Time Tracking

Estimated:

Remaining:

Logged:

45m