Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73392

Sticky table elements in grade report view are now broken

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-73392-master
    • Hide
      1. Login as admin
      2. Create a new course with a few students and add a few activities to the course and use long activity names (add about 7). You can also create an "S size" course using the "Make test course" development tool.
      3. Navigate to the course gradebook.
      4. Ensure there are enough activities so you need to scroll horizontally to see all.
      5. Scroll to the right.
      6. Verify the gradebook headers + users column sticks to the left of the page when right-scrolling.
      Show
      Login as admin Create a new course with a few students and add a few activities to the course and use long activity names (add about 7). You can also create an "S size" course using the "Make test course" development tool. Navigate to the course gradebook. Ensure there are enough activities so you need to scroll horizontally to see all. Scroll to the right. Verify the gradebook headers + users column sticks to the left of the page when right-scrolling.

      This is a regression caused by MDL-72095.

      To see it:

      1. Enrol a bunch of students in a course (10 is fine)
      2. Create a bunch of activities (depening on the length of their names, 5 or 6 should be enough. Just need them to be wider than the viewport in the grade report)
      3. Go to the course grade report
      4. Scroll right and observe the firstname/surname column is no longer sticky. It should stick to the left of the viewport when scrolling
      5. Scroll up and down and observe the Overall average row (the last row), is no longer sticky. It should stick to the bottom of the viewport.

      Reverting all the commits from 72095 restores the expected behavior here.

        1. MDL-73392 testing.webm
          759 kB

            basbrands Bas Brands
            jaked Jake Dallimore
            Ferran Recio Ferran Recio
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 40 minutes
                1h 40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.