Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73393

Ensure that existing third party themes still work with navigation 4.0 changes

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-73393-master
    • Hide

      Requires elevated privileges

      Setup:

      1. A course with an activity in it
      2. Install and the Fordson theme following the instructions https://docs.moodle.org/311/en/Installing_a_new_theme
        1. Fordson - https://moodle.org/plugins/theme_fordson
        2. In the "New settings - Fordson" page, set "Block Display Location Options" to "Single Column Boost Default"
      3. Apply the attached patch - fordson.patch (fixes a few issue with the current version of the theme)

      Testing

      1. Log in as admin
      2. Confirm you do not see an error message indicating a missing 'nav-drawer' file
      3. Go to the dashboard if not on it.
      4. Confirm you can see the hamburger icon on the top left
      5. Click on the icon
      6. Confirm you see the side bar with some content (we don't care about the content)
      7. Go to the course
      8. Go to the activity
      9. Turn on editing if not on already.
      10. Confirm you see the 'Add a block' button in the side bar.
      Show
      Requires elevated privileges Setup: A course with an activity in it Install and the Fordson theme following the instructions https://docs.moodle.org/311/en/Installing_a_new_theme Fordson - https://moodle.org/plugins/theme_fordson In the "New settings - Fordson" page, set "Block Display Location Options" to "Single Column Boost Default" Apply the attached patch - fordson.patch (fixes a few issue with the current version of the theme) Testing Log in as admin Confirm you do not see an error message indicating a missing 'nav-drawer' file Go to the dashboard if not on it. Confirm you can see the hamburger icon on the top left Click on the icon Confirm you see the side bar with some content (we don't care about the content) Go to the course Go to the activity Turn on editing if not on already. Confirm you see the 'Add a block' button in the side bar.
    • 1
    • Navigation push 14, QA time

    Description

      I've been testing the new changes with existing popular themes to ensure that we haven't broken them.

      Themes checked so far:

      • Adaptable
      • Moove
      • Fordson
      • Academi
      • Eguru
      • Snap
      • Klass

      Fordson, Academi and others are using the nav-drawer.mustache template which we have perhaps over zealously removed. I propose that we put that back. None of our code uses it, and so putting that file back will not return the nav drawer in new boost.

      It also looks like themes that use the site administration page in Boost can only see the first tab. We may want to see if we can fix that as well.

      Removing the course settings cog has left many themes with no access to course settings.

      The Snap theme looks pretty broken and I have no idea what the cause is.

      I've had another review of these third party plugins and here is the list of things to do:

      1. Put nav-drawer.mustache back.
        1. Add a deprecation comment on the file and create an issue to remove the template.
      2. Add "add a block" back to the flat navigtaion in navigationlib.php (This lets themes add navigation blocks back if needed).
        1. Deprecate the flat navigation class.

       

      Attachments

        1. fordson.patch
          2 kB
        2. MDL-73393_1.png
          MDL-73393_1.png
          120 kB
        3. MDL-73393_2.png
          MDL-73393_2.png
          100 kB
        4. MDL-73393_3.png
          MDL-73393_3.png
          318 kB

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-73732 Exception can occur on the pages that do not have active node in navigation

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-74311 Final deprecation flat_navigation classes

          • Minor - Minor loss of function where workaround is possible
          • Open
          is documented by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-73714 Document and inform the public about changes to theme plugins

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              peterdias Peter Dias
              abgreeve Adrian Greeve
              Mihail Geshoski Mihail Geshoski
              Victor Déniz Falcón Victor Déniz Falcón
              Angelia Dela Cruz Angelia Dela Cruz
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              3 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 15 minutes
                  1d 1h 15m