-
Bug
-
Resolution: Fixed
-
Major
-
4.0
-
MOODLE_400_STABLE
-
MOODLE_400_STABLE
-
MDL-73393-master -
-
1
-
Navigation push 14, QA time
I've been testing the new changes with existing popular themes to ensure that we haven't broken them.
Themes checked so far:
- Adaptable
- Moove
- Fordson
- Academi
- Eguru
- Snap
- Klass
Fordson, Academi and others are using the nav-drawer.mustache template which we have perhaps over zealously removed. I propose that we put that back. None of our code uses it, and so putting that file back will not return the nav drawer in new boost.
It also looks like themes that use the site administration page in Boost can only see the first tab. We may want to see if we can fix that as well.
Removing the course settings cog has left many themes with no access to course settings.
The Snap theme looks pretty broken and I have no idea what the cause is.
I've had another review of these third party plugins and here is the list of things to do:
- Put nav-drawer.mustache back.
- Add a deprecation comment on the file and create an issue to remove the template.
- Add "add a block" back to the flat navigtaion in navigationlib.php (This lets themes add navigation blocks back if needed).
- Deprecate the flat navigation class.
- has a non-specific relationship to
-
MDL-73732 Exception can occur on the pages that do not have active node in navigation
-
- Closed
-
- has been marked as being related by
-
MDL-74311 Final deprecation flat_navigation classes
-
- Open
-
- is documented by
-
MDL-73714 Document and inform the public about changes to theme plugins
-
- Closed
-