[MDL-73402] Admin bookmarks block is too aggressive at cleaning bookmarked section - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.4
Fix Version/s: 3.11.5
Component/s: Administration, Blocks
Labels:

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
git://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-73402~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-73402-311
Pull Master Branch:
~~MDL-73402~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-73402
Testing Instructions:
Hide

Login as admin

Ensure Admin bookmarks block is present and shown on all admin pages (it is by default)

Navigate to Plugins > Activity modules > Quiz > Safe Exam Browser templates in site administration

In the Admin bookmarks block, press Bookmark this page

Confirm page is now listed in admin bookmarks

In the Admin bookmarks block, press Unbookmark this page

Confirm page is no longer listed in admin bookmarks
Show
Login as admin Ensure Admin bookmarks block is present and shown on all admin pages (it is by default) Navigate to Plugins > Activity modules > Quiz > Safe Exam Browser templates in site administration In the Admin bookmarks block, press Bookmark this page Confirm page is now listed in admin bookmarks In the Admin bookmarks block, press Unbookmark this page Confirm page is no longer listed in admin bookmarks

Description

This was reported by a Workplace partner (WP-3073 for reference), in that it's not possible to bookmark certain pages because of overly zealous cleaning of the section name in the bookmarks block:

https://github.com/moodle/moodle/blob/58a729f08871d0bdd4a27fe54327999c9b81dd0e/blocks/admin_bookmarks/create.php#L33

This is a problem when sections contain slashes, such as here:

https://github.com/moodle/moodle/blob/58a729f08871d0bdd4a27fe54327999c9b81dd0e/mod/quiz/accessrule/seb/classes/template_controller.php#L120-L125

There doesn't appear to be any actual restriction/definition on what the content of a page $name is or should be:

https://github.com/moodle/moodle/blob/58a729f08871d0bdd4a27fe54327999c9b81dd0e/lib/adminlib.php#L1216-L1219

In Workplace, this affects the certificate plugins

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-73402_master.webm
339 kB
29/Dec/21 5:57 PM
MDL-73402_v311.webm
287 kB
29/Dec/21 5:56 PM

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Marina Glancy

Integrator:: Sara Arjona (@sarjona)

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, Marina Glancy, Paul Holden, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 17/Dec/21 7:32 PM

Updated:: 11/Jan/22 11:03 PM

Resolved:: 30/Dec/21 6:53 PM

Fix Release Date:: 17/Jan/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 10m