Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73467

HTML should be removed from report schedules for non-supported formats

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 4.0
    • 4.0
    • Report builder
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      Prerequisites

      1. Email is configured on your site (use Mailhog or Mailcatcher for testing locally)

      Setup

      1. Login as admin
      2. Create a new user
      3. Navigate to Reports > Report builder > Custom reports in site administration
      4. Create a new report from the Users report source
        • Ensure Include default setup is unchecked
      5. Add the following columns to the report:
        • User > Full name with link
        • User > Email address
      6. Press the Audience tab
      7. Add the Manually added users audience
        • Select the admin user
      8. Press the Schedules tab
      9. Press New schedule
        • Name: My schedule
        • Starting from: 1 January 2030 09:00
        • Audience: Manually added users: Admin User
        • Subject: Hello
        • Body: Hola

      Test sending

      Note: Repeat the following steps for each of the following formats:

      • Comma-separated values (.csv)
      • Microsoft Excel (.xlsx)
      • HTML table - Supports HTML
      • Javascript Object Notation (.json)
      • OpenDocument (.ods)
      • Portable Document Format (.pdf) - Supports HTML
      1. Press Edit schedule details
      2. Set Format to the format being tested.
      3. Save the changes.
      4. Press Send schedule (the envelope icon)
      5. Press Confirm in subsequent dialogue
      6. Run cron. "php admin/cli/cron.php"
      7. Confirm you receive an email to the admin account
      8. If the format does support HTML:
        • Confirm the first column of the emailed attachment is a clickable link to the users' profile
      9. If the format does not support HTML:
        • Confirm the first column of the emailed attachment contains only the users' full name in plain text and without HTML markup.
      Show
      Prerequisites Email is configured on your site (use Mailhog or Mailcatcher for testing locally) Setup Login as admin Create a new user Navigate to Reports > Report builder > Custom reports in site administration Create a new report from the Users report source Ensure Include default setup is unchecked Add the following columns to the report: User > Full name with link User > Email address Press the Audience tab Add the Manually added users audience Select the admin user Press the Schedules tab Press New schedule Name: My schedule Starting from: 1 January 2030 09:00 Audience: Manually added users: Admin User Subject: Hello Body: Hola Test sending Note: Repeat the following steps for each of the following formats: Comma-separated values (.csv) Microsoft Excel (.xlsx) HTML table - Supports HTML Javascript Object Notation (.json) OpenDocument (.ods) Portable Document Format (.pdf) - Supports HTML Press Edit schedule details Set Format to the format being tested. Save the changes. Press Send schedule (the envelope icon) Press Confirm in subsequent dialogue Run cron. " php admin/cli/cron.php " Confirm you receive an email to the admin account If the format does support HTML: Confirm the first column of the emailed attachment is a clickable link to the users' profile If the format does not support HTML: Confirm the first column of the emailed attachment contains only the users' full name in plain text and without HTML markup.

    Description

      Custom report schedules (MDL-72598) should follow the same logic re. removing report HTML as when exporting the report manually (MDL-73275)

      Both the aforementioned issues were integrated at the same time, so neither addressed the other

      Fix that here

      Attachments

        1. MDL-73467_csv.webm
          696 kB
        2. MDL-73467_html table.webm
          882 kB
        3. MDL-73467_json.webm
          659 kB
        4. MDL-73467_ods.webm
          686 kB
        5. MDL-73467_pdf.webm
          968 kB
        6. MDL-73467_xlsx.webm
          850 kB

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Carlos Castillo Carlos Castillo
              Jun Pataleta Jun Pataleta
              Angelia Dela Cruz Angelia Dela Cruz
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 20 minutes
                  5h 20m

                  Clockify

                    Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.