-
Improvement
-
Resolution: Fixed
-
Minor
-
4.0
-
MOODLE_400_STABLE
-
MOODLE_400_STABLE
-
As requested by sarjona in her review of MDL-72598: https://tracker.moodle.org/browse/MDL-72598?focusedCommentId=893655&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-893655
I have only one comment: I think the reportbuilder/templates/local/toggle.mustache you have created should be moved to the main library and be added to the component UI library. I'm not going to block this issue for that (because we're trying to introduce the Component library little by little, as we did with other features in the past, such as unit tests), but I think it should be done before the 4.0 release. Please, could you create a new issue and prepare a patch for it