Loading...

XML

Word

Printable

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/bmbrands/moodle.git
Pull Main Branch:
~~MDL-73486~~-master
Pull Main Diff URL:
https://github.com/bmbrands/moodle/compare/541d999d27...MDL-73486-master
Testing Instructions:
Hide

For this test you will need access to the console, have nodejs installed and be able to run command 'grunt css'

Login to your console

Navigate to your Moodle's root folder

Run "npm install"

Run "npm install -g grunt"

Run "grunt css"

Verify the output for running "Stylelint:css" has no warnings
Show
For this test you will need access to the console, have nodejs installed and be able to run command 'grunt css' Login to your console Navigate to your Moodle's root folder Run "npm install" Run "npm install -g grunt" Run "grunt css" Verify the output for running "Stylelint:css" has no warnings

While they aren't errors and everything passes and work ok, there are a few warnings when running stylelint:

$ npx grunt css

Running "ignorefiles" task

Running "stylelint:scss" (stylelint) task

>> Linted 166 files without errors

Running "sass:dist" (sass) task

Running "ignorefiles" task

Running "stylelint:css" (stylelint) task

>> blocks/private_files/styles.css

>>  52:144  ⚠  Expected line length to be no more than 132 characters   max-line-length

>>  53:144  ⚠  Expected line length to be no more than 132 characters   max-line-length

>>  68:158  ⚠  Expected line length to be no more than 132 characters   max-line-length

>> Linted 116 files without errors

Done.

it would be great to get rid of them. Don't know if via ignore annotations or really shortening the lines, I'm happy with any.

Absolutely not-critical, but better get 100% green executions.

Ciao

Participants:: Angelia Dela Cruz, Bas Brands, CiBoT, Eloy Lafuente (stronk7), Luca Bösch, Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

40m