Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73497

Upgrade to Spout 3.3.0 the 311_STABLE branch

    XMLWordPrintable

Details

    • MOODLE_311_STABLE
    • MOODLE_311_STABLE
    • MDL-73497_311
    • Hide

      Important note

      Run the tests below both with php73 and php80

      Manual test

      1. Navigate to Users > Accounts > Bulk user actions in site administration
      2. Press Add all
      3. Select With selected users: Download and press Go
      4. Select from Export users as and press Download for each of the following formats (those using the Spout library)
        • Comma separated values (.csv)
        • Microsoft Excel (.xlsx)
        • OpenDocument (.ods)
      5. Confirm each exported file is formatted appropriately according to it's type

      Automated test

      $ vendor/bin/phpunit lib/tests/dataformat_test.php

      Show
      Important note Run the tests below both with php73 and php80 Manual test Navigate to Users > Accounts > Bulk user actions in site administration Press Add all Select With selected users: Download and press Go Select from Export users as and press Download for each of the following formats (those using the Spout library) Comma separated values (.csv) Microsoft Excel (.xlsx) OpenDocument (.ods) Confirm each exported file is formatted appropriately according to it's type Automated test $ vendor/bin/phpunit lib/tests/dataformat_test.php

    Description

      Right now, in 311_STABLE we are using Spout 3.1.0

      The first official version of Spout supporting PHP 8.0 was Spout 3.2.0 (link).

      Moodle 4.0 (current master) was already upgraded to Spout 3.3.0 some months ago @ MDL-71707.

      This issue is basically about to perform the same upgrade of the library for 311_STABLE, in order to ensure that we aren't going to face PHP 8.0 problems there.

      Ciao

      Attachments

        Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-71707 Upgrade Box::Spout to latest version

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-71695 Review third party libraries for new versions (4.0 release)

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Paul Holden Paul Holden
              Jun Pataleta Jun Pataleta
              Gladys Basiana Gladys Basiana
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                17/Jan/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 30 minutes
                  5h 30m