-
Bug
-
Resolution: Fixed
-
Minor
-
3.11.4, 3.11.5, 4.0
-
MOODLE_311_STABLE, MOODLE_400_STABLE
-
MOODLE_311_STABLE
-
This issue removes code that only was being executed by php < 73 and it's 100% safe to do so because Moodle 3.11 and up require php 73, hence it was not executed ever.
Removed code includes:
- ldap_control_paged_result and ldap_control_paged_result_response (that were deprecated in php 73 and have been removed in php 80).
- conditional code in the session manager, where some hacks were needed for php < 73. Note that this removes the private function append_samesite_cookie_attribute() completely because it was doing nothing (first line was returning for PHP >= 73).
- Also removed the old session.hash_function ini setting because it was removed in php 71.
Kept code includes:
- The environmental check_igbinary322_version test has not been removed because it doesn't hurt (always returns "ok" for php 73 sites) and doing it would involve to backport the environment.xml file to 39 and 310. Instead, a note has been added to
MDL-71747in order to get rid of that check for 4.1 and up.
- has a non-specific relationship to
-
MDL-71747 Decide Moodle 4.1 requirements and push them to environment.xml (due date: 2022-06-01)
- Closed
- is duplicated by
-
MDL-73589 Remove old branch of code in enrol/ldap/lib.php once PHP 7.3.0 becomes required
- Closed
-
MDL-73590 Remove old branch of code in auth/ldap/auth.php once PHP 7.3.0 becomes required
- Closed
- Testing discovered
-
MDL-73700 Remove all the old php version checks from core
- Waiting for integration review