Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73502

get_magic_quotes_xxx functions removed in php80

XMLWordPrintable

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • Hide
      • Sanity check. Verify that the changes (a block of code removal and a function_exists() new check) make sense.
      • Leave this into automated testing hands. I've tried to find how to reach that code but have failed to come with any manual testing instructions.
      Show
      Sanity check. Verify that the changes (a block of code removal and a function_exists() new check) make sense. Leave this into automated testing hands. I've tried to find how to reach that code but have failed to come with any manual testing instructions.

      The get_magic_quotes_gpc() and get_magic_quotes_runtime() functions were deprecated in php74 (always returning false).

      In php80 they have been removed and now they throw an error.

      This issue is about to review all existing cases, ensuring that:

      • they are being executed conditionally [OR]
      • if not conditionally, modify code to always consider the "false" value that they were returning in previous php versions.

      List of files to inspect (also added the set, that was removed in php 5.x!):

      $ ag '(set|get)_magic_quotes' -l
      enrol/lti/ims-blti/OAuth.php
      lib/tcpdf/include/tcpdf_static.php
      lib/tcpdf/CHANGELOG.TXT
      lib/pear/README_MOODLE.txt
      lib/horde/framework/Horde/Util.php
      lib/htmlpurifier/HTMLPurifier/Config.php
      h5p/h5plib/v124/joubel/editor/ckeditor/samples/old/assets/posteddata.php
      

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Paul Holden Paul Holden
            Jun Pataleta Jun Pataleta
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 31 minutes
                1h 31m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.