[MDL-73685] Error on /admin/roles/admins.php if email removed from identity fields - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0, 4.0.2, 4.0.4
Fix Version/s: 4.0.4
Component/s: Administration
Labels:
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull 4.0 Branch:
~~MDL-73685~~-admin-role-bug-MOODLE_400_STABLE
Pull 4.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_400_STABLE...brendanheywood:MDL-73685-admin-role-bug-MOODLE_400_STABLE
Pull Master Branch:
~~MDL-73685~~-admin-role-bug
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...brendanheywood:moodle:MDL-73685-admin-role-bug
Testing Instructions:
Hide

Turn on debugging mode on by adding the following bit to your config.php or run mdk run dev command

$CFG->debug = (E_ALL | E_STRICT); // DEBUG_DEVELOPER

$CFG->debugdisplay = 1;

Have at least 2 users created on the site.

As admin visit Administration > Users > Permissions > User policies

Deselect 'Email address' and Save changes.

Visit Administration > Users > Permissions > Site administrators

Add another user as admin.

Confirm there are no errors
Show
Turn on debugging mode on by adding the following bit to your config.php or run mdk run dev command $CFG->debug = (E_ALL | E_STRICT); // DEBUG_DEVELOPER $CFG->debugdisplay = 1 ; Have at least 2 users created on the site. As admin visit Administration > Users > Permissions > User policies Deselect 'Email address' and Save changes. Visit Administration > Users > Permissions > Site administrators Add another user as admin. Confirm there are no errors

Description

On my 4.0 dev site the email is unchecked in User policies > Show user identities. When I go to add a new site admin or check existing admins an error appears:
Notice: Undefined property: stdClass::$email in /opt/app/admin/roles/classes/admins_existing_selector.php on line 90

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

errorsiteadmin.png
56 kB
26/Jan/22 2:25 AM
MDL-73685_master.png
59 kB
01/Sep/22 3:27 PM
MDL-73685_v400.png
56 kB
01/Sep/22 3:27 PM

Issue Links

is a regression caused by

MDL-69498 Break down the Manage site administrators by email domain and sort

Closed

Activity

People

Assignee:: Brendan Heywood

Reporter:: Mary Cooch

Peer reviewer:: Andrew Madden

Integrator:: Simey Lameze

Tester:: John Edward Pedregosa

Participants:: Andrew Madden, Brendan Heywood, CiBoT, John Edward Pedregosa, Jun Pataleta, Mary Cooch, Simey Lameze, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 26/Jan/22 2:23 AM

Updated:: 08/Sep/22 1:49 PM

Resolved:: 02/Sep/22 1:31 PM

Fix Release Date:: 12/Sep/22

Time Tracking

Estimated:

Remaining:

Logged:

54m