Loading...

XML

Word

Printable

Type: Task
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 4.0, 4.1, 4.5
Component/s: General
Labels:
- ci
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull Main Branch:
MDL-73700_remove-all-the-old-php-version-checks-from-core
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-73700_remove-all-the-old-php-version-checks-from-core
Testing Instructions:
Hide

Verify all CI Tests (PHPUnit and Behat) run through without warnings.

Verify that the following command only returns entries for 3^rd-party libraries.

ag 'PHP_VERSION(_ID)?|PHP_MAJOR_VERSION|(check_|restrict_|require_minimum_)?php_version\('

Note: The ag command is available from https://github.com/ggreer/the_silver_searcher and can probably be found in your OS package repository.
Show
Verify all CI Tests ( PHPUnit and Behat ) run through without warnings. Verify that the following command only returns entries for 3 rd -party libraries. ag 'PHP_VERSION(_ID)?|PHP_MAJOR_VERSION|(check_|restrict_|require_minimum_)?php_version\(' Note: The ag command is available from https://github.com/ggreer/the_silver_searcher and can probably be found in your OS package repository.
Pre-check results:
Hide

Code verified against automated checks with warnings.

Checked MDL-73700 using repository: https://github.com/ziegenberg/moodle

main (0 errors / 3 warnings) [branch: MDL-73700_remove-all-the-old-php-version-checks-from-core | CI Job]

overview (0/0), phplint (0/0), phpcs (0/1), js (0/0), css (0/0), phpdoc (0/0), commit (0/1), savepoint (0/0), thirdparty (0/1), externalbackup (0/0), grunt (0/0), shifter (0/0), mustache (0/0), gherkin (0/0),

Should these errors be fixed?

Built on: Wed Jan 22 10:46:35 AM UTC 2025
Show
Code verified against automated checks with warnings. Checked MDL-73700 using repository: https://github.com/ziegenberg/moodle main (0 errors / 3 warnings) [branch: MDL-73700_remove-all-the-old-php-version-checks-from-core | CI Job ] overview (0/0) , phplint (0/0) , phpcs (0/1) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (0/1) , savepoint (0/0) , thirdparty (0/1) , externalbackup (0/0) , grunt (0/0) , shifter (0/0) , mustache (0/0) , gherkin (0/0) , Should these errors be fixed? Built on: Wed Jan 22 10:46:35 AM UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-73700_remove-all-the-old-php-version-checks-from-core

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17580/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59865/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59866/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59867/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59868/ App tests (stable app version)

Built on: Fri Nov 29 04:25:16 AM UTC 2024
Show
Launching automatic jobs for branch MDL-73700 _remove-all-the-old-php-version-checks-from-core https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/17580/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59865/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59866/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59867/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/59868/ App tests (stable app version) Built on: Fri Nov 29 04:25:16 AM UTC 2024

This comes from ~~MDL-73500~~, where a number of php < 73 checks were removed from core because they contained deprecated / removed functionality in php 80.

There, it was detected that we still have a good number of old checks in code (some dating back to php 5x).

And, all them, are 100% unnecessary/unreachable code tight now, because Moodle 3.11 (and up) requires php 73. And surely Moodle 4.1 will require php 74.

So this issue is about to remove all those checks and the branches of code being executed for those old php versions.

Note this does not apply to 3rd part libraries.

Ciao

Discovered while testing

MDL-73500 Remove all the conditional code looking for php < 73

Closed

duplicates

MDL-64482 Review not needed anymore PHP 5.x & 7.0 checks uses in core

Closed

has been marked as being related by

MDL-83398 Change session.serialize_handler to 'php_serialize'

Open

MDL-83675 Final deprecation of check_igbinary322_version()

Open

MDL-83470 Decide Moodle 5.0 requirements and push them to environment.xml (due date: 15 Nov 2024)

Closed

MDL-83349 PR only: MDL-73700 - Remove all the old php version checks from core

Closed

MDL-83379 PR only (2) : MDL-73700 - Remove all the old php version checks from core

Closed

split to

MDL-83398 Change session.serialize_handler to 'php_serialize'

Open

MDL-84259 Remove all the old php version checks from mod_lti

Closed

(2 has been marked as being related by, 2 split to)

Assignee:: Daniel Ziegenberg

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Meirza

Integrator:: Sara Arjona (@sarjona)

Participants:: CiBoT, Daniel Ziegenberg, Eloy Lafuente (stronk7), Jake Dallimore, Meirza, Paul Holden, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 27/Jan/22 5:14 PM

Updated:: 2 days ago 1:20 AM

Estimated:

Not Specified

Remaining:

Logged:

5h 12m

Details

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify