Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73732

Exception can occur on the pages that do not have active node in navigation

XMLWordPrintable

    • 3
    • Navigation push 14

      Was initially reported in MDL-73674 but seems like it's a different problem.

      There is a bug in the function flat_navigation_node::isactive() , it does not really cause any problems on LMS but can easily happen in the custom themes.

      If you apply this change:
      https://github.com/moodle/moodle/compare/master...marinaglancy:MDL-73674-master-test

      and then visit Participants page in any course in topics format you'll get an exception:

      Trying to get property 'parent' of non-object in /home/marina/repositories/lms/master/moodle/lib/navigationlib.php on line 3975

      Side note: I do not understand why the contents of $PAGE->flatnav depends on whether it is first requested before or after $PAGE->secondarynav

        1. MDL-73732_testing.webm
          2.05 MB

            sujith Sujith Haridasan
            marina Marina Glancy
            Peter Dias Peter Dias
            Shamim Rezaie Shamim Rezaie
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 14 minutes
                1d 14m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.