Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.3.5, 4.4.1
Affects Version/s: 4.0, 4.3.4
Component/s: Course
Labels:
- ci
- partner
- patch
- release_notes
- synergy-learning
- triaged

Affected Branches:
MOODLE_400_STABLE, MOODLE_403_STABLE
Fixed Branches:
MOODLE_403_STABLE, MOODLE_404_STABLE
Pull from Repository:
https://github.com/ziegenberg/moodle
Pull 4.3 Branch:
~~MDL-73735~~-M403_duplicate-line-course-rest-php
Pull 4.3 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_403_STABLE...ziegenberg:MDL-73735-M403_duplicate-line-course-rest-php
Pull 4.4 Branch:
~~MDL-73735~~-M404_duplicate-line-course-rest-php
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...ziegenberg:MDL-73735-M404_duplicate-line-course-rest-php
Pull Main Branch:
~~MDL-73735~~_duplicate-line-course-rest-php
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...ziegenberg:MDL-73735_duplicate-line-course-rest-php
Testing Instructions:
Hide

Add a new course and remember its course id as COURSE_ID.

Create two activities, named "Activity One" and "Activity Two" in the general section, with "Activity One" above "Activity Two".

Remember the module IDs of the two activities with "Activity One" as MOD1_ID and "Activity Two" as MOD2_ID.

Get the sesskey for your session as SESSKEY

Enter the following URL in the browser:

[MOODLE_SITE]/course/rest.php?courseId=COURSE_ID&class=resource&field=move&id=MOD2_ID&beforeId=MOD1_ID&sesskey=SESSKEY

and replace the placeholders.

Verify the order of the activities has changed.
Show
Add a new course and remember its course id as COURSE_ID . Create two activities, named "Activity One" and "Activity Two" in the general section, with "Activity One" above "Activity Two". Remember the module IDs of the two activities with "Activity One" as MOD1_ID and "Activity Two" as MOD2_ID . Get the sesskey for your session as SESSKEY Enter the following URL in the browser: [MOODLE_SITE]/course/rest.php?courseId=COURSE_ID&class=resource&field=move&id=MOD2_ID&beforeId=MOD1_ID&sesskey=SESSKEY and replace the placeholders. Verify the order of the activities has changed.

Very minor issue, but line 80 of course/rest.php ( https://github.com/moodle/moodle/blob/master/course/rest.php#L80 ) calls get_coursemodule_from_id() and stores the result in $beforemod.

The very next line, calls $DB->get_record('course_modules', ...) - then uses it to populate exactly the same $beforemod variable.

Unless I've missed something incredibly subtle here, the second line is completely unnecessary and should just be deleted (the first line is the more correct of the two).

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

MDL-73735.png
148 kB
05/Jun/24 9:55 AM

Assignee:: Daniel Ziegenberg

Reporter:: Davo Smith

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Amaia Anabitarte

Tester:: Ron Carl Alfon Yu

Participants:: Amaia Anabitarte, Carlos Escobedo, CiBoT, Daniel Ziegenberg, Davo Smith, Huong Nguyen, Ron Carl Alfon Yu, Sara Arjona (@sarjona)

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 01/Feb/22 8:42 PM

Updated:: 06/Jun/24 11:44 PM

Resolved:: 06/Jun/24 11:44 PM

Estimated:

Not Specified

Remaining:

Logged:

2h 2m

Details

Description

Attachments

Attachments

Activity

People

Dates

Time Tracking

Clockify