-
Bug
-
Resolution: Fixed
-
Blocker
-
4.0
-
MOODLE_400_STABLE
-
MOODLE_400_STABLE
-
MDL-73747-master -
-
-
Moppies Kanban
This has been detected on MDL-73279.
During the upgrade to remove loggedin/loggedoff pairs, the permitted setting was migrated to a new locked setting. But new locked setting was only saved on the database to reduce DB space. See code here.
Also, message_send does not work if "locked" preference is not set on the DB (see code here. Same happens on send_message_to_conversation here.
I found two possible solutions for that.
- Adding a new upgrade step where we check the enabled "%provider%_enabled" setting (it should always exist), and then add a locked setting "%provider%_locked" to 0 if it does not exist on the DB:
SELECT * FROM mdl_config_plugins WHERE PLUGIN = 'message' AND name LIKE '%provider%_enabled' - Change the behaviour of both functions to check for _enabled setting to exist on the DB instead of _locked (a new function to get enabled processor list would be a great benefit) for us and 3rd party.
An easy way to reproduce the issue is to delete all rows on mdl_config_plugins where name is "%_locked" and plugin is 'message' and try to send a notification.
- Discovered while testing
-
MDL-73279 BigBlueButton setting duplicates the setting 'Send content change notification'
-
- Closed
-
- has a non-specific relationship to
-
MDL-73982 Improve information saved in the database for Notification settings
-
- Open
-
- has been marked as being related by
-
MDL-73905 Wrong coding_exception used on problems sending messages
-
- Closed
-
-
MDL-73592 Enable MoodleNet integration by default
-
- Closed
-
- is a regression caused by
-
MDL-67853 Remove online-offline options on notifications.
-
- Closed
-
-
MDL-73592 Enable MoodleNet integration by default
-
- Closed
-
- is duplicated by
-
MDL-73939 tool_moodlenet uses message_send() API during upgrade
-
- Closed
-
- Testing discovered
-
MDL-73749 Simplify the options to sections and weeks format hiddensections
-
- Open
-