Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73764

Reconcile install.xml files with XMLDB Editor output

XMLWordPrintable

      While working on a fix to install/upgrade structures @ MDL-71696 , it has been detected that, right now, there are a bunch of differences between the current install.xml and what the XMLDB editor saves.

      The differences are not critical (they are mainly whitespace and some attribute out of order).

      But we need to reconcile this, so anybody using the editor only sees the real changes and not all those mistmatches.

      At the same time, a new job (added to TODO lists) should ensure that the files are reconciled always. That will also help, sometimes, to blame people editing them by hand.

      To reproduce:

      • Go to admin -> dev -> xmldb editor.
      • Edit lib/db (the main one) and add any tiny change, in a comment or whatever.
      • Save it.

      Expected:

      • Only that tiny change should happen if you make a git diff.

      Current:

      • There are a lot of changes with differences in whitespace or attributes order, completely unrelated with the tiny change performed.

      Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Andrew Lyons Andrew Lyons
            Ilya Tregubov Ilya Tregubov
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 50 minutes
                2h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.