[MDL-73765] Scheduled task are randomly allocated to 0 - 23 minutes range only - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/mudrd8mz/moodle.git
Pull 3.11 Branch:
~~MDL-73765~~-311-twenty-three-minutes
Pull 3.11 Diff URL:
https://github.com/mudrd8mz/moodle/compare/8f46c10cb8...MDL-73765-311-twenty-three-minutes
Pull Master Branch:
~~MDL-73765~~-master-twenty-three-minutes
Pull Master Diff URL:
https://github.com/mudrd8mz/moodle/compare/e63604fb6d...MDL-73765-master-twenty-three-minutes
Testing Instructions:
Hide

Log in as an admin

Go to Site administration > Server > Tasks > Scheduled tasks

Edit the schedule of the 'Background processing for tags' (\core\task\tag_cron_task) task

Check 'Reset task schedule to defaults' and save changes

TEST - Check that the new schedule has the minute set to a random value from the range 0 - 59

TEST - Repeat few times if needed and check that the random minute is sometimes also set to a value higher than 23.
Show
Log in as an admin Go to Site administration > Server > Tasks > Scheduled tasks Edit the schedule of the 'Background processing for tags' (\core\task\tag_cron_task) task Check 'Reset task schedule to defaults' and save changes TEST - Check that the new schedule has the minute set to a random value from the range 0 - 59 TEST - Repeat few times if needed and check that the random minute is sometimes also set to a value higher than 23.

This code from ~~MDL-47221~~ is a copy & paste mistake:

    public function set_minute($minute, $expandr = true) {

        if ($minute === 'R' && $expandr) {

            $minute = mt_rand(self::HOURMIN, self::HOURMAX);

        $this->minute = $minute;

It should read MINUTEMIN and MINUTEMAX.

As a result, all randomly allocated tasks have always get random minute from the range 0 - 23 only.

Discovered while testing

MDL-73748 All sites check for available updates on the hour, every two hours

has a non-specific relationship to

MDL-74242 Fix update checks default to random ( backport of MDL-73748 & MDL-73765)

has been marked as being related by

MDL-47221 Allow a 'random' value to be set in scheduled tasks time definition

Participants:: CiBoT, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Gladys Basiana, Luca Bösch

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Estimated:

Not Specified

Remaining:

Logged:

1h 3m