Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73797

Dialog should have the action button on the right

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0
    • 4.0
    • Usability
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      Save/cancel dialogs

      1. Log in as admin
      2. Create a course
      3. Add an activity
      4. Press Edit > Delete for the activity
      5. Confirm the confirmation dialog shows the buttons ordered [ Cancel, Yes ]
      6. Add a block
      7. Press Actions menu > Delete [...] for the block
      8. Confirm the confirmation dialog shows the buttons ordered [ Cancel, Delete ]
      Show
      Save/cancel dialogs Log in as admin Create a course Add an activity Press Edit > Delete for the activity Confirm the confirmation dialog shows the buttons ordered [ Cancel, Yes ] Add a block Press Actions menu > Delete [...] for the block Confirm the confirmation dialog shows the buttons ordered [ Cancel, Delete ]

      As commented by dougiamas in MDL-33130:

      1) OS X, Windows and Ubuntu ALL put the "Cancel" button on the left and the action button on the right.

      2) This makes sense to me because dialogs are like a step in a process/story, and we are used to moving left to right in those situations (is probably reversed for RTL speakers). "Cancel" is like going BACK while "Save" or 'Add" in this case is like going FORWARD.

      Also jverdaguer highlighted the inconsistency between Moodle and the Moodle app, which has the action button on the right.

      Thus, let's change the order of the dialog buttons to have the action button on the right.

        1. dialogue_boxes.png
          dialogue_boxes.png
          158 kB
        2. photo_2022-02-10_08-59-54.jpg
          photo_2022-02-10_08-59-54.jpg
          11 kB
        3. Step No. 5_Screenshot.PNG
          Step No. 5_Screenshot.PNG
          11 kB
        4. Step No. 8_Screenshot.PNG
          Step No. 8_Screenshot.PNG
          13 kB

            pholden Paul Holden
            tsala Helen Foster
            Ferran Recio Ferran Recio
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Gladys Basiana Gladys Basiana
            Votes:
            1 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 35 minutes
                1h 35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.