Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73797

Dialog should have the action button on the right

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0
    • 4.0
    • Usability
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      Save/cancel dialogs

      1. Log in as admin
      2. Create a course
      3. Add an activity
      4. Press Edit > Delete for the activity
      5. Confirm the confirmation dialog shows the buttons ordered [ Cancel, Yes ]
      6. Add a block
      7. Press Actions menu > Delete [...] for the block
      8. Confirm the confirmation dialog shows the buttons ordered [ Cancel, Delete ]
      Show
      Save/cancel dialogs Log in as admin Create a course Add an activity Press Edit > Delete for the activity Confirm the confirmation dialog shows the buttons ordered [ Cancel, Yes ] Add a block Press Actions menu > Delete [...] for the block Confirm the confirmation dialog shows the buttons ordered [ Cancel, Delete ]

    Description

      As commented by dougiamas in MDL-33130:

      1) OS X, Windows and Ubuntu ALL put the "Cancel" button on the left and the action button on the right.

      2) This makes sense to me because dialogs are like a step in a process/story, and we are used to moving left to right in those situations (is probably reversed for RTL speakers). "Cancel" is like going BACK while "Save" or 'Add" in this case is like going FORWARD.

      Also jverdaguer highlighted the inconsistency between Moodle and the Moodle app, which has the action button on the right.

      Thus, let's change the order of the dialog buttons to have the action button on the right.

      Attachments

        Issue Links

          caused a regression

          Improvement - An enhancement to an existing Moodle feature. MDL-74252 Document position of the cancel button in Dialogs

          • Minor - Minor loss of function where workaround is possible
          • Open
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-33130 Dialogue unification project for 2.3

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-74259 Forms should have the action button on the right

          • Minor - Minor loss of function where workaround is possible
          • Reopened

          Improvement - An enhancement to an existing Moodle feature. MDL-75031 Server side confirmation prompts should have the action button on the right

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              pholden Paul Holden
              tsala Helen Foster
              Ferran Recio Ferran Recio
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Gladys Basiana Gladys Basiana
              Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May, David Woloszyn, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 35 minutes
                  1h 35m