Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73805

Added left margin to icons causes layout issues in multiple pages

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 4.0
    • 3.11.6
    • Themes
    • MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • MDL-73805-311
    • MDL-73805-master
    • Hide

      Verify the left margin is removed

      1. login as admin
      2. open the message drawer
      3. click your own username to send yourself a message
      4. hover over the emoji icon
      5. Verify it is centred in the hover background (light gray)

      navigation spacing in recentlyaccessedcourses block

      1. Create some courses or use existing ones.
      2. Enrol yourself to at least 2 courses
      3. Add "Recently acessed courses" block to your Dashboard.
      4. Verify there's a bit of space between the paging bar and the move icon:
      Show
      Verify the left margin is removed login as admin open the message drawer click your own username to send yourself a message hover over the emoji icon Verify it is centred in the hover background (light gray) navigation spacing in recentlyaccessedcourses block Create some courses or use existing ones. Enrol yourself to at least 2 courses Add "Recently acessed courses" block to your Dashboard. Verify there's a bit of space between the paging bar and the move icon:

    Description

      The added left margin to the .icon css class introduced in MDL-73543 is causing layout issues in the course index, message drawer, form UI and possibly more places.

      It should be reverted and only applied where it is required

      Attachments

        1. MDL-73543 margin.png
          MDL-73543 margin.png
          4 kB
        2. MDL-73805_left margin.png
          MDL-73805_left margin.png
          109 kB
        3. MDL-73805_navigation spacing.png
          MDL-73805_navigation spacing.png
          81 kB
        4. MDL-73805 after.png
          MDL-73805 after.png
          23 kB
        5. MDL-73805 before.png
          MDL-73805 before.png
          23 kB
        6. photo_2022-02-08 10.04.48.jpeg
          photo_2022-02-08 10.04.48.jpeg
          52 kB
        7. Screenshot 2022-02-08 at 10.02.40.png
          Screenshot 2022-02-08 at 10.02.40.png
          19 kB
        8. Screenshot 2022-02-08 at 10.04.27.png
          Screenshot 2022-02-08 at 10.04.27.png
          57 kB

        Issue Links

          Activity

            People

              basbrands Bas Brands
              basbrands Bas Brands
              Simey Lameze Simey Lameze
              Jun Pataleta Jun Pataleta
              Angelia Dela Cruz Angelia Dela Cruz
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Mar/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 44 minutes
                  1h 44m