Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73836

Report actions don't allow caller to specify title attribute manually

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      Setup

      1. Apply the MDL-73836.diff patch to your site

      Test

      1. Log in as admin
      2. Navigate to Reports > Report builder > Custom reports in site administration
      3. Create a new report named "My cool report"
      4. Close the editor, to get back to the list of reports
      5. Confirm the first action for each report row has the title Perform action on: My cool report
      Show
      Setup Apply the MDL-73836.diff patch to your site Test Log in as admin Navigate to Reports > Report builder > Custom reports in site administration Create a new report named "My cool report" Close the editor, to get back to the list of reports Confirm the first action for each report row has the title Perform action on: My cool report

    Description

      It's possible for system reports to create actions while manually specifying $attributes['title'] - unfortunately this is always overwritten in the action class (here)

      The use case is for actions containing dynamic titles according to current row content, e.g. setting the title to "Perform action on ':attribute'" - will attach a patch to demo/reproduce use case we have in Workplace

      This is a small regression from MDL-73166 - pinging mikelmartíncorrales for his thoughts!

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Mikel Martín Corrales Mikel Martín Corrales
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Angelia Dela Cruz Angelia Dela Cruz
              Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days, 40 minutes
                  4d 40m