Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73846

"Prepare submissions for annotation" task tries to process the whole queue in one go

XMLWordPrintable

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • MDL-73846-master
    • Hide

      The patch is fully covered by unit tests.

      Unit test can be run manually (ghostscript needs to be installed):

      vendor/bin/phpunit --testsuite='assignfeedback_editpdf_testsuite' --filter='test_conversion_task_limit'

      Show
      The patch is fully covered by unit tests. Unit test can be run manually ( ghostscript needs to be installed): vendor/bin/phpunit --testsuite= 'assignfeedback_editpdf_testsuite' --filter= 'test_conversion_task_limit'

      The '\assignfeedback_editpdf\task\convert_submissions' scheduled task has no limit when selecting records from the mdl_assignfeedback_editpdf_queue table
      https://github.com/moodle/moodle/blob/589724236163476bdcf2310c2542b992dbfb9c7b/mod/assign/feedback/editpdf/classes/task/convert_submissions.php#L57

      The task basically tries to process the whole queue in one go.

      When there are lots of records in the queue, the tasks runs for many hours and then eventually dies or gets terminated. It seems like having a limit here will give admins more control under the task.

            mikhailgolenkov Misha Golenkov
            mikhailgolenkov Misha Golenkov
            Dmitrii Metelkin Dmitrii Metelkin
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            10 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 20 minutes
                20m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.