[MDL-73895] Don't display notification categories if they are empty - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.5
Fix Version/s: 3.11.6
Component/s: Messages
Labels:
- ci
- triaged

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE
Epic Link:
Moodle configurations follow-ups
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-73895~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-73895-311
Pull Master Branch:
~~MDL-73895~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-73895
Testing Instructions:
Hide

Log in as admin

Navigate to Messaging > Notification settings in site administration

Disable Assignment notifications and press Save changes

Select Preferences from your user menu (top-right of the page)

Press User Account > Notification preferences

Confirm there is no empty Assignment component heading

3.11 only:

Confirm the presence of Online/Offline help icons at the top of the table
Show
Log in as admin Navigate to Messaging > Notification settings in site administration Disable Assignment notifications and press Save changes Select Preferences from your user menu (top-right of the page) Press User Account > Notification preferences Confirm there is no empty Assignment component heading 3.11 only: Confirm the presence of Online/Offline help icons at the top of the table

Description

Steps to reproduce

Login as admin.
Access to Site administration > Messaging > Notification settings.
Disable all the notifications from a category (for instance, "Assignment notifications" in the "Assignment" category).
Go to the user Notification preferences (/message/notificationpreferences.php?userid=x).

Current behaviour

The assignment category is displayed (although it doesn't contain any notification setting).

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

assignmentcategoryempty.png
62 kB
16/Feb/22 1:52 AM
MDL-73895_master.png
99 kB
11/Mar/22 5:39 PM
MDL-73895_v311.png
109 kB
11/Mar/22 5:39 PM

Issue Links

will help resolve

MDL-73894 Ideas for reducing the number of notification preferences

Open

Activity

People

Assignee:: Paul Holden

Reporter:: Sara Arjona (@sarjona)

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Jun Pataleta

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, Jun Pataleta, Paul Holden, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 16/Feb/22 1:51 AM

Updated:: 11/Mar/22 7:21 PM

Resolved:: 11/Mar/22 7:21 PM

Fix Release Date:: 14/Mar/22

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

1h 20m