Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74109

Using deprecated SCSS-PHP compile() method

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74109-master
    • Hide
      1. Using your favourite editor, edit theme/styles.php.
      2. On line 27 change NO_DEBUG_DISPLAY value to false.
      3. Now edit lib/scssphp/Compiler.php.
      4. On line 436 remove the leading @ from trigger_error() call.
      5. In your browser, access the following url: 

        http://{HOSTNAME}/stable_master/theme/styles.php?theme=boost&type=editor

      6. Make sure you don't see the following deprecation error: 

        <b>Deprecated</b>:  The "ScssPhp\ScssPhp\Compiler::compile" method is deprecated. Use "compileString" instead. in <b>/home/simey/moodles/stable_master/moodle/lib/scssphp/Compiler.php</b> on line <b>436</b><br />

      7. Make sure the css content is served as before.
      Show
      Using your favourite editor, edit theme/styles.php . On line 27 change NO_DEBUG_DISPLAY value to false . Now edit lib/scssphp/Compiler.php . On line 436 remove the leading @ from trigger_error() call. In your browser, access the following url: http://{HOSTNAME}/stable_master/theme/styles.php?theme=boost&type=editor Make sure you don't see the following deprecation error: <b>Deprecated</b>: The "ScssPhp\ScssPhp\Compiler::compile" method is deprecated. Use "compileString" instead. in <b>/home/simey/moodles/stable_master/moodle/lib/scssphp/Compiler.php</b> on line <b>436</b><br /> Make sure the css content is served as before.
    • 1
    • HQ Team International CIH2-220

      Was running the very first behat runs locally (Mac and Win), towards completing the 4.0 testing release matrix, when I've seen in apache logs, happening a number of times, this:

      Debugging: Error while compiling editor SCSS: Unknown error type: The "ScssPhp\ScssPhp\Compiler::compile" method is deprecated. Use "compileString" instead. in /Users/stronk7/git_moodle/testing/lib/scssphp/Compiler.php on line 436 in 
      * line 1019 of /lib/outputlib.php: call to debugging()
      		 
      * line 1318 of /lib/outputlib.php: call to theme_config->editor_scss_to_css()
      		 
      * line 129 of /theme/styles.php: call to theme_config->get_css_content_editor()

      That debugging wasn't there a few months ago when we ran MDL-72815 (examine apache logs before 4.0).

      Somehow related, MDL-71706 has been integrated between the 2 apache logs examinations (thanks sarjona!).

        1. MDL-74109_Test Passed.PNG
          MDL-74109_Test Passed.PNG
          74 kB

            lameze Simey Lameze
            stronk7 Eloy Lafuente (stronk7)
            Huong Nguyen Huong Nguyen
            Victor Déniz Falcón Victor Déniz Falcón
            Gladys Basiana Gladys Basiana
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 42 minutes
                4h 42m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.