Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74120

CACHE_DISABLE_ALL causes exception when cache::make is called repeatedly for definition with data source

    XMLWordPrintable

Details

    • Bug
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.9.12
    • None
    • Caching
    • None
    • MOODLE_39_STABLE

    Description

      MDL-42012 Added support for definitions with data sources when cache is disabled, but introduced a bug where calling cache::make producing the same cache definition with a data source more than once will reuse the same definition and in set_identifiers will throw a coding_exception because identifiers is not null.

      I'm new to moodle and inherited a project so not familiar enough with moodle to reproduce as a phpunit test. Tried to create a stripped down local plugin which will trigger the issue on running the admin/cli/install.php script (which was how we found it) to illustrate the issue in the attachment.

      Attachments

        Activity

          People

            Unassigned Unassigned
            Elgorath Lars Mikal Rogne
            Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: