[MDL-74131] Flagged tags font colour has insufficient contrast with the background colour - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.5, 4.0
Fix Version/s: 3.11.6
Component/s: Tags, Themes, UX
Labels:
- UX
- ci
- hqteam_charlie
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/aanabit/moodle.git
Pull 3.11 Branch:
~~MDL-74131~~-311
Pull 3.11 Diff URL:
https://github.com/aanabit/moodle/compare/MDL-74131-311~...MDL-74131-311
Pull Master Branch:
~~MDL-74131~~-master
Pull Master Diff URL:
https://github.com/aanabit/moodle/compare/MDL-74131-master~...MDL-74131-master
Testing Instructions:
Hide

Login as admin and edit your own profile.

Add some tags as interests and Update profile.

Go to Site administration > Appearance > Manage tags

Click on 'Default collection'

Click on the 'Flag' icon for any of the existing tags.

Confirm the background of the whole row changes to orange for the flagged tag.

Confirm the font color of the flagged tag has not change.

Click on the 'Flag' icon to unflagged the flagged tag.

Confirm the background of the row is not orange anymore.

Confirm the font color of the unflagged tag has not change.

Click on the 'Flag' icon for any of the existing tags.

Switch to edit on mode and Add 'Tags' block.

Confirm the color of the flagged tag is orange.

Click on the flagged tag.

Confirm the color of the tag name on the header is orange.
Show
Login as admin and edit your own profile. Add some tags as interests and Update profile. Go to Site administration > Appearance > Manage tags Click on 'Default collection' Click on the 'Flag' icon for any of the existing tags. Confirm the background of the whole row changes to orange for the flagged tag. Confirm the font color of the flagged tag has not change. Click on the 'Flag' icon to unflagged the flagged tag. Confirm the background of the row is not orange anymore. Confirm the font color of the unflagged tag has not change. Click on the 'Flag' icon for any of the existing tags. Switch to edit on mode and Add 'Tags' block. Confirm the color of the flagged tag is orange. Click on the flagged tag. Confirm the color of the tag name on the header is orange.

Sprint:
Moppies Kanban

Description

As noticed by sbourget in ~~MDLQA-16481~~, flagged tags are no longer red, but orange. The orange colour is a problem because there is insufficient contrast between the font colour and the background colour.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

3-flagged-boost.png
319 kB
09/Mar/22 4:49 PM
image-2022-03-10-16-41-46-942.png
32 kB
10/Mar/22 11:42 PM
image-2022-03-10-16-43-35-872.png
9 kB
10/Mar/22 11:43 PM
manage tags.png
55 kB
09/Mar/22 4:49 PM
MDL-74131_Test Passed.png
219 kB
16/Mar/22 11:59 AM
Screenshot 2022-03-09 at 10.17.36.png
537 kB
09/Mar/22 5:23 PM

Issue Links

blocks

MDLQA-16481 CLONE - A manager can manage tags used on the site

Passed

Discovered while testing

MDLQA-15835 CLONE - A manager can manage tags used on the site

Passed

Activity

People

Assignee:: Amaia Anabitarte

Reporter:: Helen Foster

Peer reviewer:: Carlos Escobedo

Integrator:: Eloy Lafuente (stronk7)

Tester:: Gladys Basiana

Participants:: Amaia Anabitarte, Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Gladys Basiana, Helen Foster, Rafael Lechugo

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May, Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 08/Mar/22 11:23 PM

Updated:: 19/Mar/22 12:08 AM

Resolved:: 19/Mar/22 12:08 AM

Fix Release Date:: 14/Mar/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

4h 25m