Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74276

Third party reports can stop access to all other reports.

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74276-master-linkfarm
    • Hide

      Requirements

      1. A sample course
      2. Admin access

      Testing

      1. Log in as admin
      2. Go to the course created earlier
      3. Click on the reports tab in the secondary navigation
      4. Confirm you see a page with a list of available reports
      5. Go to Site admin > Plugins > Plugin overview
      6. Uninstall the following:
        1. block_completionstatus
        2. All reports under the "Reports" section except for report_loglive
      7. Apply the patch MDL-74298_core_Render_complete_links_when_searching_for_a_setting.patch 

        git am MDL-74298_core__Render_complete_links_when_searching_for_a_setting_.patch

      8. Go to the course
      9. Confirm you see the 'Reports' tab
      10. Click on the Reports tab
      11. Confirm you see a message 'No reports accessible'
      12. Confirm you do not see the Log live report listed
      13. Repeat #5
      14. Uninstall Log live report
      15. Go to the course
      16. Confirm you do not see a reports tab in the secondary navigation
      17. Click on the 'Home' tab in the primary navigation
      18. Confirm you do not see the 'Reports' tab
      Show
      Requirements A sample course Admin access Testing Log in as admin Go to the course created earlier Click on the reports tab in the secondary navigation Confirm you see a page with a list of available reports Go to Site admin > Plugins > Plugin overview Uninstall the following: block_completionstatus All reports under the "Reports" section except for report_loglive Apply the patch MDL-74298_core_ Render_complete_links_when_searching_for_a_setting .patch git am MDL-74298_core__Render_complete_links_when_searching_for_a_setting_.patch Go to the course Confirm you see the 'Reports' tab Click on the Reports tab Confirm you see a message 'No reports accessible' Confirm you do not see the Log live report listed Repeat #5 Uninstall Log live report Go to the course Confirm you do not see a reports tab in the secondary navigation Click on the 'Home' tab in the primary navigation Confirm you do not see the 'Reports' tab
    • 3
    • QA time 2

      As reported by Eric Merrill, the Ally report is positioned first on the list, and redirects out of Moodle. This means that the list of other reports is never shown and there is no way to access them.

      Proposal:
      We detect whether there are any third party plugins that extend the report node (probable performance problem). If there are third party reports then when the user clicks the reports tab, we go to an interim page that has all of the reports in the select menu. If the report isn't a core report then we have a message below the select menu that says something like "This report could send you outside of Moodle. Click this link to open the report in a new tab." Clicking the link would open the report in a new tab.

        1. MDL-74276 testing_1.png
          MDL-74276 testing_1.png
          26 kB
        2. MDL-74276 testing_2.png
          MDL-74276 testing_2.png
          31 kB
        3. MDL-74276 testing_3.png
          MDL-74276 testing_3.png
          21 kB
        4. MDL-74276 testing_4.png
          MDL-74276 testing_4.png
          32 kB
        5. MDL-74276 testing_5.png
          MDL-74276 testing_5.png
          113 kB
        6. MDL-74298_core__Render_complete_links_when_searching_for_a_setting_.patch
          0.9 kB

            peterdias Peter Dias
            abgreeve Adrian Greeve
            Mihail Geshoski Mihail Geshoski
            Jake Dallimore Jake Dallimore
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 3 hours, 20 minutes
                1d 3h 20m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.