[MDL-74279] LTI errors during unit tests on sqlsrv, caused by AdoDB tests changing logging options - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 3.11.7
Component/s: Authentication, Enrolments, Unit tests
Labels:
- ci
- triaged

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull 3.11 Branch:
~~MDL-74279~~_311
Pull 3.11 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-74279_311~1...MDL-74279_311
Pull Master Branch:
~~MDL-74279~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-74279~1...MDL-74279
Workaround:

Hide

Do not run auth_db or enrol_database tests with SQL*Server :-P

Show
Do not run auth_db or enrol_database tests with SQL*Server :-P
Testing Instructions:

Hide

Just ensure that PHPUnit jobs @ CIs with the patch applied aren't getting, in the console any "sqlsrv_query" debugging anymore.

You can find some runs below, in the comments (by ToBiC)

Show
Just ensure that PHPUnit jobs @ CIs with the patch applied aren't getting, in the console any "sqlsrv_query" debugging anymore. You can find some runs below, in the comments (by ToBiC)

Description

Seen on Moodle CI: https://ci.moodle.org/view/B%20-%20master/job/W.01.04%20-%20PHPUnit%20-%20MSSQL/1829/console

........................................................... 12685 / 19070 ( 66%)

......................................sqlsrv_query: SQLSTATE = 23000

sqlsrv_query: error code = 2601

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Cannot insert duplicate key row in object 'dbo.t_enrol_lti_app_registration' with unique index 't_enroltiappregi_pla_uix'. The duplicate key value is (1f308714aaa22ea1bfb352a5db424300a8e42fa4f74c57f37122510e6573d38c).

sqlsrv_query: SQLSTATE = 01000

sqlsrv_query: error code = 3621

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The statement has been terminated.

.........sqlsrv_query: SQLSTATE = 23000

sqlsrv_query: error code = 2601

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Cannot insert duplicate key row in object 'dbo.t_enrol_lti_context' with unique index 't_enrolticont_lticon_uix'. The duplicate key value is (1, CTX123).

sqlsrv_query: SQLSTATE = 01000

sqlsrv_query: error code = 3621

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The statement has been terminated.

........sqlsrv_query: SQLSTATE = 23000

sqlsrv_query: error code = 2601

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Cannot insert duplicate key row in object 'dbo.t_enrol_lti_deployment' with unique index 't_enroltidepl_pladep_uix'. The duplicate key value is (1, Deploy_ID_123).

sqlsrv_query: SQLSTATE = 01000

sqlsrv_query: error code = 3621

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The statement has been terminated.

.... 12744 / 19070 ( 66%)

...............sqlsrv_query: SQLSTATE = 23000

sqlsrv_query: error code = 2601

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Cannot insert duplicate key row in object 'dbo.t_enrol_lti_resource_link' with unique index 't_enroltiresolink_reslti_uix'. The duplicate key value is (res-link-1, 1).

sqlsrv_query: SQLSTATE = 01000

sqlsrv_query: error code = 3621

sqlsrv_query: message = [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]The statement has been terminated.

............................................ 12803 / 19070 ( 67%)

........................................................... 12862 / 19070 ( 67%)

& Workplace: https://ci.moodle.org/view/MW/job/MW400.01.03%20-%20PHPUnit%20-%20MSSQL/34/console (same errors as above)

Note the error is absent from Workplace 311 tests, and Moodle 311 tests (thanks stronk7, also for suggesting relation to ~~MDL-74138~~)

Last important note, that these exceptions strangely don't cause test failures

Attachments

Issue Links

has been marked as being related by

MDL-74138 Incorrectly defined unique key in auth/lti/upgrade.php

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Paul Holden

Peer reviewer:: Jake Dallimore

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Jun Pataleta, Paul Holden, ToBiC

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 21/Mar/22 5:07 PM

Updated:: 30/Mar/22 12:17 AM

Resolved:: 30/Mar/22 12:17 AM

Fix Release Date:: 9/May/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

4h 15m