Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74312

Tool endpoints should use a button instead of an <a> tag for the trigger element

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74312-400
    • MDL-74312-master
    • Hide

      Behat already covers copying these URLs to clipboard but we can test space activation of the now-button element.

      1. Log in to the site
      2. Enable "Publish as LTI tool" enrolment plugin via Site admin > Plugins > Enrolments > Manage enrolments
      3. Go to Site admin > Plugins > Enrolments > Publish as LTI tool > Tool registration
      4. Create a new registration, just using a dummy name (anything is fine)
      5. After clicking continue, when you see the "Tool details" screen, confirm the following:

      • You can copy each URL to clipboard by clicking the button next to the field
      • You can tab to the button
      • After tabbing to the button, you can activate it by pressing space
      • After tabbing to the button, you can activate it by pressing enter
      Show
      Behat already covers copying these URLs to clipboard but we can test space activation of the now-button element. 1. Log in to the site 2. Enable "Publish as LTI tool" enrolment plugin via Site admin > Plugins > Enrolments > Manage enrolments 3. Go to Site admin > Plugins > Enrolments > Publish as LTI tool > Tool registration 4. Create a new registration, just using a dummy name (anything is fine) 5. After clicking continue, when you see the "Tool details" screen, confirm the following: You can copy each URL to clipboard by clicking the button next to the field You can tab to the button After tabbing to the button, you can activate it by pressing space After tabbing to the button, you can activate it by pressing enter
    • 1
    • 4.1 holding pattern

    Description

      This is just a small change aimed at fixing the behaviour of this copy to clipboard, allowing the space key to work as a trigger for copying URLs, which currently isn't the case. I think this should be a button since it acts like an action.

      Attachments

        Issue Links

          Activity

            People

              jaked Jake Dallimore
              jaked Jake Dallimore
              Mihail Geshoski Mihail Geshoski
              Victor Déniz Falcón Victor Déniz Falcón
              Carlos Escobedo Carlos Escobedo
              Jake Dallimore, Mathew May, Mihail Geshoski
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/May/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 40 minutes
                  1h 40m