[MDL-74321] Increased DB reads on forum - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 3.11 Branch:
~~MDL-74321~~-311
Pull 3.11 Diff URL:
https://github.com/junpataleta/moodle/compare/49171c9f6e...MDL-74321-311
Pull Main Branch:
~~MDL-74321~~-master
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/efda17d3b0...MDL-74321-master
Testing Instructions:
Hide

Unit tests cover this.

Something for the integrator:

Compare the performance run with the patch applied to the last on-demand release (efda17d3b02) and confirm that the DB reads have decreased.

Compare the performance run with the patch applied to the on-demand release before the last one (34ce1463ccc) and confirm that the DB reads have not changed.
Show
Unit tests cover this. Something for the integrator: Compare the performance run with the patch applied to the last on-demand release (efda17d3b02) and confirm that the DB reads have decreased. Compare the performance run with the patch applied to the on-demand release before the last one (34ce1463ccc) and confirm that the DB reads have not changed.

After ~~MDL-74121~~, we noticed an increase in DB queries in forum activities.

See the following performance test results:

between before - 400 (34ce1463ccc on-de...) and after - 400 (06eded2a8bc Merge...)

dbreads: increment - View a forum activity, 16% worse

dbreads: increment - View a forum discussion, 142.37% worse

dbreads: increment - Fill a form to reply a forum discussion, 74.38% worse

dbreads: increment - Send the forum discussion reply, 2.63% worse

dbreads: increment - All steps data combined, 21.99% worse

dbquerytime: increment - View a forum activity, 12.75% worse

dbquerytime: increment - View a forum discussion, 92.01% worse

dbquerytime: increment - Fill a form to reply a forum discussion, 68.32% worse

dbquerytime: increment - All steps data combined, 17.97% worse

timeused: increment - View a forum discussion, 23.85% worse

timeused: increment - Fill a form to reply a forum discussion, 21.54% worse

is a regression caused by

MDL-74121 Modal error displayed when the posting threshold in forum is exceeded

Participants:: CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Victor Déniz Falcón

Estimated:

Not Specified

Remaining:

Logged:

5h 30m