Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74321

Increased DB reads on forum

    XMLWordPrintable

Details

    • MOODLE_311_STABLE
    • MOODLE_311_STABLE
    • MDL-74321-311
    • MDL-74321-master
    • Hide

      Unit tests cover this.

      Something for the integrator:

      1. Compare the performance run with the patch applied to the last on-demand release (efda17d3b02) and confirm that the DB reads have decreased.
      2. Compare the performance run with the patch applied to the on-demand release before the last one (34ce1463ccc) and confirm that the DB reads have not changed.
      Show
      Unit tests cover this. Something for the integrator: Compare the performance run with the patch applied to the last on-demand release (efda17d3b02) and confirm that the DB reads have decreased. Compare the performance run with the patch applied to the on-demand release before the last one (34ce1463ccc) and confirm that the DB reads have not changed.

    Description

      After MDL-74121, we noticed an increase in DB queries in forum activities. 

       See the following performance test results:

      between before - 400 (34ce1463ccc on-de...) and after - 400 (06eded2a8bc Merge...)
      		 
      dbreads: increment - View a forum activity, 16% worse
      		 
       
      		 
      dbreads: increment - View a forum discussion, 142.37% worse
      		 
       
      		 
      dbreads: increment - Fill a form to reply a forum discussion, 74.38% worse
      		 
       
      		 
      dbreads: increment - Send the forum discussion reply, 2.63% worse
      		 
       
      		 
      dbreads: increment - All steps data combined, 21.99% worse
      		 
       
      		 
      dbquerytime: increment - View a forum activity, 12.75% worse
      		 
       
      		 
      dbquerytime: increment - View a forum discussion, 92.01% worse
      		 
       
      		 
      dbquerytime: increment - Fill a form to reply a forum discussion, 68.32% worse
      		 
       
      		 
      dbquerytime: increment - All steps data combined, 17.97% worse
      		 
       
      		 
      timeused: increment - View a forum discussion, 23.85% worse
      		 
       
      		 
      timeused: increment - Fill a form to reply a forum discussion, 21.54% worse

      Attachments

        1. forum_check_throttling coverage.png
          4 kB
          Jun Pataleta
        2. perf_comparison_with_march_16.pdf
          432 kB
          Eloy Lafuente (stronk7)

        Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-74121 Modal error displayed when the posting threshold in forum is exceeded

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              jpataleta Jun Pataleta
              jpataleta Jun Pataleta
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Victor Déniz Falcón Victor Déniz Falcón
              CiBoT CiBoT
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/May/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 30 minutes
                  5h 30m