Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74377

Fix styles for dropdown items inside dimmed_text elements

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74377-400
    • Hide

      Setup

      1. Log in as administrator
      2. Navigate to Reports in the user menu
      3. Press New report button
      4. Set any report name.
      5. Set Report source to "Courses"
      6. Press Save
      7. Click on Audience tab
      8. Add All users audience and press Save changes
      9. Click on Schedules tab
      10. Press New schedule
        1. Select a schedule Name
        2. Select All users: All site users audience
        3. Select a Subject and a Body
      11. Press Save

      Test dropdown menu inside a dimmed row

      1. Click on the toggle button to disable the schedule
      2. Confirm that the schedule row is dimmed
      3. Confirm that the dropdown icon is displayed normally (not dimmed)
      4. Click on the action menu dropdown icon for the dimmed schedule
      5. Confirm that the dropdown actions are displayed normally (not dimmed)

      Test applying text-muted to a dropdown-item directly

      1. Using the browser inspector, add "text-muted" class to the "dropdown-item menu-action" element in the schedule row ("Delete schedule" action for example)
      2. Confirm that the "Delete schedule" dropdown item is displayed with dimmed text
      Show
      Setup Log in as administrator Navigate to Reports in the user menu Press New report button Set any report name. Set Report source to "Courses" Press Save Click on Audience tab Add All users audience and press Save changes Click on Schedules tab Press New schedule Select a schedule Name Select All users: All site users audience Select a Subject and a Body Press Save Test dropdown menu inside a dimmed row Click on the toggle button to disable the schedule Confirm that the schedule row is dimmed Confirm that the dropdown icon is displayed normally (not dimmed) Click on the action menu dropdown icon for the dimmed schedule Confirm that the dropdown actions are displayed normally (not dimmed) Test applying text-muted to a dropdown-item directly Using the browser inspector, add "text-muted" class to the "dropdown-item menu-action" element in the schedule row ("Delete schedule" action for example) Confirm that the "Delete schedule" dropdown item is displayed with dimmed text

    Description

      Elements inside a ".dimmed_text" should have the text dimmed (including dropdown-toggle link), but not the "dropdown-item" elements inside the dropdown itself.

      It should be still possible to add "dimmed_text" to the "dropdown-item" directly in case it could be necessary.

      Without the patch:

      With the patch:

       

      Attachments

        Issue Links

          Activity

            People

              mikelmartíncorrales Mikel Martín Corrales
              mikelmartíncorrales Mikel Martín Corrales
              Paul Holden Paul Holden
              Jun Pataleta Jun Pataleta
              Gladys Basiana Gladys Basiana
              Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo, Carlos Castillo, David Matamoros, Mikel Martín Corrales, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Jul/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 55 minutes
                  4h 55m