Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
3.11.6
-
MOODLE_311_STABLE
-
MOODLE_311_STABLE, MOODLE_400_STABLE
-
MDL-74436-311 -
MDL-74436-400 -
- Log in as admin
- Create a course
- 311
- Select Calendar from navigation drawer
- Press Manage subscriptions
- master
- Add the Calendar block to the course
- Press Import or export calendars
- Press Import calendar
- Enter a Calendar name
- Import from: Calendar file
- Upload icalexport.ics
- Type of event: Course (leave the Course field empty)
- Submit form
- Confirm the Course field shows Select a course error
- Change Type of event: Category
- Clear the Category field (it should say No selection)
- Submit form
- Confirm the Category field shows Required error
Regression test
- Now change Type of event: Course and select a course
- Submit form
- Confirm the events were imported into the selected course
- Navigate back to the calendar import page
- Upload the same file again
- Change Type of event: Category and select a category
- Submit form
- Confirm the events were imported into the selected category
Log in as admin Create a course 311 Select Calendar from navigation drawer Press Manage subscriptions master Add the Calendar block to the course Press Import or export calendars Press Import calendar Enter a Calendar name Import from: Calendar file Upload icalexport.ics Type of event: Course (leave the Course field empty) Submit form Confirm the Course field shows Select a course error Change Type of event: Category Clear the Category field (it should say No selection ) Submit form Confirm the Category field shows Required error Regression test Now change Type of event: Course and select a course Submit form Confirm the events were imported into the selected course Navigate back to the calendar import page Upload the same file again Change Type of event: Category and select a category Submit form Confirm the events were imported into the selected category
Description
To replicate:
- Add $CFG->calendar_adminseesall = true; to config.php
- Create a course and add the calendar block
- Click the "Import or export calendars" link on the block
- Press the "Import calendar" button
- Set "Import from" to "Calendar file (.ics)
- Upload an ics file (there's one attached to this issue that you can use)
- Set "Type of event" to "Course"
- Press "Import calendar"
I guess the issue is that the user is expected to select a course when using the "Course" event type, but the UI doesn't indicate that field is required, nor does it appear to do any validation upon submission.
