Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.0
Affects Version/s: 4.0
Component/s: Course
Labels:
- ci
- regression

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-74459~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-74459
Testing Instructions:
Hide

(To be tested with both Firefox and Chrome)

Test

Log in as admin

Create a course

Press Settings in secondary navigation

Toggle course index & block drawer open/close

Confirm open/closing both works

Regression test (~~MDL-74222~~)

Using your browser DOM tools, inspect the Expand/collapse all link

Confirm it contains aria-controls="..." attribute whose content is the ID of each fieldset expand/collapse link
Show
(To be tested with both Firefox and Chrome) Test Log in as admin Create a course Press Settings in secondary navigation Toggle course index & block drawer open/close Confirm open/closing both works Regression test ( MDL-74222 ) Using your browser DOM tools, inspect the Expand/collapse all link Confirm it contains aria-controls="..." attribute whose content is the ID of each fieldset expand/collapse link

Seems to be in at least 3 cases:

Navigate to course; Press Settings in secondary navigation; Toggle course index (either open/show it, depending on current state)
Navigate to forum; Add discussion topic; Press Advanced; Toggle course index
Navigate to forum Settings; Toggle course index
... there may be other cases elsewhere (common theme appears to be when the page has a form)

Each time, trying to toggle course index fails. When trying to press Close course index the button just disappears (the course index is still visible)

Following exception was observed in browser console each time:

Uncaught Error: cannot call methods on tooltip prior to initialization; attempted to call method 'hide'

    jQuery 5

    openDrawer http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    toggleVisibility http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    <anonymous> http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    EventListener.handleEvent* http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    <anonymous> http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    execCb http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    setTimeout handler*req.nextTick< http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    requirejs http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    <anonymous> http://localhost:8000/course/edit.php?id=2:2897

    execCb http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    h http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    completeLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    onScriptLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    fetch http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    h http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    completeLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    onScriptLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    fetch http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    setTimeout handler*req.nextTick< http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    requirejs http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    <anonymous> http://localhost:8000/course/edit.php?id=2:2835

jquery-3.6.0.min.js:2:2616

    jQuery 5

    openDrawer http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    toggleVisibility http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    <anonymous> http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    (Async: EventListener.handleEvent)

    <anonymous> http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    <anonymous> http://localhost:8000/lib/requirejs.php/1649363871/core/first.js:4226

    execCb http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    (Async: setTimeout handler)

    nextTick http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    requirejs http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    <anonymous> http://localhost:8000/course/edit.php?id=2:2897

    execCb http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    emit http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    h http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    completeLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    onScriptLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    (Async: EventListener.handleEvent)

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    fetch http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    h http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    completeLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    onScriptLoad http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    (Async: EventListener.handleEvent)

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    load http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    fetch http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    check http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    bind http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    each http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    enable http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    init http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    (Async: setTimeout handler)

    nextTick http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    o http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    requirejs http://localhost:8000/lib/javascript.php/1649363871/lib/requirejs/require.min.js:5

    <anonymous> http://localhost:8000/course/edit.php?id=2:2835

Edit opening/closing the block drawer also produces same errors

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

Regression test _Screenshot.PNG
107 kB
12/Apr/22 12:39 PM
Test_Screenshot1.PNG
61 kB
12/Apr/22 12:38 PM
Test_Screenshot2.PNG
56 kB
12/Apr/22 12:38 PM

caused a regression

MDL-75459 Form collapsing JavaScript fails if you have a form where all sections are initially expanded

Closed

has been marked as being related by

MDL-75892 jqueryui sometimes get's loaded before bootstrap's javascript. This breaks the drawer collapse functionality

Closed

is a regression caused by

MDL-74222 Expand all/Collapse all should have aria-controls attribute

Closed

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Ferran Recio

Integrator:: Shamim Rezaie

Tester:: Gladys Basiana

Participants:: CiBoT, Dabulewicz, Ferran Recio, Gladys Basiana, Paul Holden, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Created:: 08/Apr/22 5:08 AM

Updated:: 28/Apr/23 3:35 PM

Resolved:: 12/Apr/22 7:57 PM

Estimated:

Remaining:

Logged:

1h 45m

Toggling course index/drawer broken, JS errors within some course/module pages

Test

Regression test (MDL-74222)

Details

Test

Regression test (MDL-74222)

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify