Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74465

Display block configuration form in a popup

XMLWordPrintable

    • MOODLE_400_STABLE, MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • MDL-74465-master-5
    • Hide

      There are quite a few behat tests but some visual/manual testing will be great

      1. Install several blocks from https://moodle.org/plugins/?q=type:block%20sort-by:sites
      2. Add blocks on the dashboard as a regular user (see notes below)
      3. Add blocks to the course page as a teacher (see notes below)
      4. Add blocks to the default dashboard as an admin (see notes below)
      5. Switch to Classic theme and try adding/configuring blocks (only one page is enough), make sure there are no bugs.
      6. Install a couple of themes from https://moodle.org/plugins/?q=type:theme%20sort-by:sites and test in them. Note that in the themes that do not provide "Add new block" button (i.e. Classic), the block configuration is displayed in a popup but when adding a block there is no second step, block is added immediately with the default configuration.

      Notes:

      • In each case try adding blocks that do and don't have ... in the end of the name (blocks that have ... display the add form in a popup). Note: currenlty "Text", "Glossary auto-linking" and "Remote RSS feed" provide the second step
      • make sure to add/configure the "RSS feed" block because it does not have automated test coverage
      • Configure each block, change the content, where it can appear, make sure the editing form is displayed in a popup
      • move blocks around using drag & drop and by clicking on the crossarow and selecting new location, make sure moving blocks works
      Show
      There are quite a few behat tests but some visual/manual testing will be great Install several blocks from https://moodle.org/plugins/?q=type:block%20sort-by:sites Add blocks on the dashboard as a regular user (see notes below) Add blocks to the course page as a teacher (see notes below) Add blocks to the default dashboard as an admin (see notes below) Switch to Classic theme and try adding/configuring blocks (only one page is enough), make sure there are no bugs. Install a couple of themes from https://moodle.org/plugins/?q=type:theme%20sort-by:sites and test in them. Note that in the themes that do not provide "Add new block" button (i.e. Classic), the block configuration is displayed in a popup but when adding a block there is no second step, block is added immediately with the default configuration. Notes: In each case try adding blocks that do and don't have ... in the end of the name (blocks that have ... display the add form in a popup). Note: currenlty "Text", "Glossary auto-linking" and "Remote RSS feed" provide the second step make sure to add/configure the "RSS feed" block because it does not have automated test coverage Configure each block, change the content, where it can appear, make sure the editing form is displayed in a popup move blocks around using drag & drop and by clicking on the crossarow and selecting new location, make sure moving blocks works
    • WP Sprint 2023-I1.2 (Marina), WP Sprint 2023-I1.3 (Marina)

      1. When user wants to change block settings - display the form in a modal popup instead of the separate page
      2. For some blocks when configuration is important, add a second step to the "Add block" popup that will allow to configure a block before it is created - for example, Text block, activity results, glossary blocks - they are useless unless they are configured

      The big challenge here is that block editing relies on permissions checks and additional setup that is done on each page and it is very difficult to implement in WS. But I think I have some ideas about how to do it

      Wish list that was not implemented under this issue (because it already grew too big):
      3. (maybe) Allow to edit block header inline
      4. (maybe) Display permissions and "check permissions" in a popup - navigating from the permission pages back to the page where the block was edited is confusing and sometimes does not work (see MDL-26675 for example)

        1. (I) Passed -- (Master)MDL-74465.png
          (I) Passed -- (Master)MDL-74465.png
          122 kB
        2. addingblock.png
          addingblock.png
          37 kB
        3. addingblock2.png
          addingblock2.png
          35 kB
        4. Screenshot 2023-03-01 at 10.01.50.png
          Screenshot 2023-03-01 at 10.01.50.png
          659 kB
        5. Screenshot 2023-03-01 at 10.02.28.png
          Screenshot 2023-03-01 at 10.02.28.png
          422 kB
        6. test-read-only-session.php
          0.4 kB

            marina Marina Glancy
            marina Marina Glancy
            David Carrillo David Carrillo
            Shamim Rezaie Shamim Rezaie
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            1 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 week, 1 day, 6 hours, 50 minutes
                1w 1d 6h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.