[MDL-74497] New methods to add all columns/filters/conditions at once - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.1
Fix Version/s: 4.1
Component/s: Report builder
Labels:
- ci

Affected Branches:
MOODLE_401_STABLE
Fixed Branches:
MOODLE_401_STABLE
Pull from Repository:
https://github.com/dravek/moodle.git
Pull Main Branch:
~~MDL-74497~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...dravek:MDL-74497-master
Testing Instructions:
Hide

Log in as admin

Select Reports from user menu

Create a new report using the "Users" data source

Confirm that all the "User" columns are shown on the left (Full name, Full name with link, etc...)

Open the Conditions dropdown and confirm that all the "User" conditions can be added to the report

Open the filters dropdown and confirm that all the "User" filters can be added to the report

Press the "Close" button

Create a new report using the "Courses" data source

Confirm that all the "Course" and "Course category" columns are shown on the left (Course full name with link, etc...)

Open the Conditions dropdown and confirm that all the "Course" and "Course category" conditions can be added to the report

Open the filters dropdown and confirm that all the "Course" and "Course category" filters can be added to the report

Press the "Close" button

Create a new report using the "Cohorts" data source

Confirm that all the "Cohort", "Cohort member" and "User" columns are shown on the left (Category, Name, etc...)

Open the Conditions dropdown and confirm that all the "Cohort", "Cohort member" and "User" conditions can be added to the report

Open the filters dropdown and confirm that all the "Cohort", "Cohort member" and "User" filters can be added to the report
Show
Log in as admin Select Reports from user menu Create a new report using the "Users" data source Confirm that all the "User" columns are shown on the left (Full name, Full name with link, etc...) Open the Conditions dropdown and confirm that all the "User" conditions can be added to the report Open the filters dropdown and confirm that all the "User" filters can be added to the report Press the "Close" button Create a new report using the "Courses" data source Confirm that all the "Course" and "Course category" columns are shown on the left (Course full name with link, etc...) Open the Conditions dropdown and confirm that all the "Course" and "Course category" conditions can be added to the report Open the filters dropdown and confirm that all the "Course" and "Course category" filters can be added to the report Press the "Close" button Create a new report using the "Cohorts" data source Confirm that all the "Cohort", "Cohort member" and "User" columns are shown on the left (Category, Name, etc...) Open the Conditions dropdown and confirm that all the "Cohort", "Cohort member" and "User" conditions can be added to the report Open the filters dropdown and confirm that all the "Cohort", "Cohort member" and "User" filters can be added to the report

Description

While converting current Workplace data sources to use the new core Report Builder we have been following this pattern quite often, sometimes even 7 times in the same data source:

// Add course entity columns/filters/conditions.

$this->add_columns_from_entity($courseentityname);

$this->add_filters_from_entity($courseentityname);

$this->add_conditions_from_entity($courseentityname);

It would be really useful to have a couple of new methods to do this at once and keep the current data sources cleaner:

->add_all_from_entity(..) To add all columns/filters/conditions from one entity.

->add_all_from_entities() To add all columns/filters/conditions from all the entities used in the data source.

The code in this example can be simplified using these new methods:

https://github.com/moodle/moodle/blob/5423e5f4435098bed40763eccbb5931a3da063a3/cohort/classes/reportbuilder/datasource/cohorts.php#L73-L86

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-74497_integration.jpg
18/May/22 5:48 PM
52 kB
Angelia Dela Cruz
MDL-74497_stable.jpg
18/May/22 5:48 PM
55 kB
Angelia Dela Cruz
MDL-74497 testing.webm
19/May/22 10:26 AM
1.62 MB
Angelia Dela Cruz

Activity

People

Assignee:: David Carrillo

Reporter:: David Carrillo

Peer reviewer:: Paul Holden

Integrator:: Jun Pataleta

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, David Carrillo, Jun Pataleta, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 13/Apr/22 10:07 PM

Updated:: 19/May/22 10:02 PM

Resolved:: 19/May/22 10:02 PM

Fix Release Date:: 28/Nov/22

Time Tracking

Estimated:

Remaining:

Logged:

2h 31m