Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74503

Swap readonly sessions from opt in to opt out

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Minor
    • None
    • Future Dev
    • Authentication, Performance
    • None

    Description

      Since MDL-58018 landed in 3.9 all of the known bugs have been ironed out and I think we are almost ready for it to be on by default.

      One barrier is the default session cache is stored in the session - but then this is also a bug because it is possible and theoretically correct for code to use MUC to cache something in the session after the session has been closed even without readonly sessions being in the equation.

      I think that we can implement a couple optional methods in the most common session stores, db and redis, which can correctly read and write session cache data without a session lock. If the configured session store declares support for this then readonly sessions would default to on. 

      The simpler alternatively is to make the default MUC session cache something not in the session and deprecate the session store, but this would negate the performance benefits.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              brendanheywood Brendan Heywood
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Clockify

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.