Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74533

The activity having wrong completion status because the system using the old grade pass to re-caculate.

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-74533-400
    • MDL-74533-master
    • Hide

      Scenario :

      Teacher setup up a quiz with those conditions:

      + Grade to pass: 10

      + Grading method: Highest grade

      + Activity completion:

      -Student must receive a grade to complete this activity

      -Student must receive a passing grade to complete this activity

      The quiz have 2 True/False questions with total grade 10.(First is 8.0 and second is 2.0)

      Student attempt the quiz with total grade is 8.0

      • Teacher go to Activity Completion report to check.

      Expected : Student is not pass activity due to not "Receive a passing grade".

      Then Teacher go to the quiz and click "Unlock completion options" and edit Grade to pass: 8.

      • Teacher go to Activity Completion report to check.

      Expected : Student is pass activity due to "Receive a passing grade".
       
       

      Show
      Scenario : Teacher setup up a quiz with those conditions: + Grade to pass: 10 + Grading method: Highest grade + Activity completion: -Student must receive a grade to complete this activity -Student must receive a passing grade to complete this activity The quiz have 2 True/False questions with total grade 10.(First is 8.0 and second is 2.0) Student attempt the quiz with total grade is 8.0 Teacher go to Activity Completion report to check. Expected : Student is not pass activity due to not "Receive a passing grade". Then Teacher go to the quiz and click "Unlock completion options" and edit Grade to pass: 8. Teacher go to Activity Completion report to check. Expected : Student is pass activity due to "Receive a passing grade".    

    Description

      Steps to reproduce:

      1. I setup a quiz with a 'Grade to pass' = 10, and then I turn on completion with these option is checked:
        Student must receive a grade to complete this activity
        Student must receive a passing grade to complete this activity
        2. As a student, I attempt the quiz and gain the grade = 9.
        =>the student receive a grade, but not a passing grade.
        3. As teacher, I change the setting of quiz, click on 'Unlock completion options' and update the 'Grade to pass' to 8
        => the student has receive a grade, and it's a passing grade. However, in the Activity Completion report, the student is FAIL the completion base on the report.

      The root cause is that: we are using the old grade pass to calculate the completion of the activity.

      We should using the new Grade to pass to calculate the completion of the activity.

       
      Note: Due to MDL-52206 is not fixed on 3.11, I will update the code changes for 4.0 and master.

       

      Attachments

        Activity

          People

            vuvanhieu143 Hieu Vu
            vuvanhieu143 Hieu Vu
            Tim Hunt Tim Hunt
            Jun Pataleta Jun Pataleta
            Gladys Basiana Gladys Basiana
            Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona), Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              11/Jul/22

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m