Regression testing Repeat the testing instructions from MDL-64843 Test the race condition is gone Create a course Login as admin in two separate sessions (e.g., a regular browser session and an incognito/private session) Edit backup/util/helper/copy_helper.class.php: Find the create_copy method Add sleep(100); on the line before the comment // Create the initial restore controller. In one of the sessions navigate to the course copy page, fill it out and submit While it's sleeping, in the other session access the course copy form Verify no errors are displayed on the screen Verify that after 100 seconds have passed you can see the course copy on the copy progress screen Test the cleanup task Remove the code edit from the previous test Browse to "Site administration" > "Courses" > "Asynchronous backup/restore" and tick the "Enable asynchronous backups"checkbox Create two courses (we'll call them A and B) In course A and B create a backup and restore it (you will need to run cron to get the backup and restore to process) In course A and course B initiate a copy and run cron to process them In course A and B create a backup but do not run cron to process them In course A and B initiate a copy but do not run cron to process them In initiate a copy in only course B but do not run cron to process it View the copy progress page (refresh it if needed) for both of the courses ( [YOUR_MOODLE] /backup/copyprogress.php?id= [COURSE_ID] ) and verify that: Course A shows one copy Course B shows two copies There are no errors Manually edit the DB record for the most recent backup controller in the mdl_backup_controllers table (sort them by ID and find the restore controller with the largest ID) setting the status to 900 to simulate a failure select max(id) from mdl_backup_controllers where operation = 'backup' ; update mdl_backup_controllers set status = 900 where id = YOURBACKUPID; Take note of the statuses of all the other controllers (best to take a screenshot or similar) select id, operation, status from mdl_backup_controllers order by id; Wait for one minute and run the cleanup task with: php admin/cli/scheduled_task.php --execute=\\core\\task\\backup_cleanup_task Check the mdl_backup_controllers table and verify that the most recent restore now has status 900 select max(id) from mdl_backup_controllers where operation = 'restore' ; select id, operation, status from mdl_backup_controllers where id = YOURRESTOREID; Compare the current state of the table with the screenshot and verify that no other controllers have changed Check the copy progress page (refresh it if needed) for each course and verify : Course A shows one copy Course B shows one copy There are no errors Manually edit the DB record for the most recent backup controller again (the same backup record from earlier), setting the status back to 700 update mdl_backup_controllers set status = 700 where id = YOURBACKUPID; Delete the most recent restore controller select max(id) from mdl_backup_controllers where operation = 'restore' ; delete from mdl_backup_controllers where id = YOURRESTOREID; Check the copy progress page (refresh it if needed) for each course and verify : Course A shows one copy Course B shows one copy There are no errors Run the cleanup task with: php admin/cli/scheduled_task.php --execute=\\core\\task\\backup_cleanup_task Check the DB and verify that the most recent backup now has its status set to 900 select max(id) from mdl_backup_controllers where operation = 'backup' ; select id, operation, status from mdl_backup_controllers where id = YOURRESTOREID; Compare with the screenshot from earlier and verify no other controllers have changed Check the copy progress page for each course and verify : Course A shows one copy Course B shows one copy There are no errors Run cron to process the remaining backups/restores/copies and verify it completes successfully Check the copy progress page for each course (refresh it if needed) and verify : Course A shows no copies Course B shows no copies There are no errors