Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-74573

"View a different attempt" link in assignments should be a button

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.11.8, 4.0.2
    • 3.9.13, 3.10.10, 3.11.6, 3.11.7, 4.0, 4.0.1
    • Assignment
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-74573-master
    • Easy
    • Hide
      1. Create a test course with an instructor and student
      2. Make an assignment
      3. In "Submission settings", set Additional attempts to "Manual" under Submission settings and set Maximum attempts to 2
      4. Log in as a test student to create a submission
      5. Log in as a teacher, view all submissions and grade the student's submission 
      6. From the "Allow another attempt " dropdown select yes to allow the student to create another submission 
      7. Log in as a test student again to create another submission
      8. Log in as an instructor, view all submissions and grade the student submission
      9. Check when you go down in the grading interface the "View a different attempt" is displayed as a button (instead of a link) 
      Show
      Create a test course with an instructor and student Make an assignment In "Submission settings", set  Additional attempts  to "Manual" under  Submission settings  and set  Maximum attempts to 2 Log in as a test student to create a submission Log in as a teacher, view all submissions and grade the student's submission  From the "Allow another attempt " dropdown select yes to allow the student to create another submission  Log in as a test student again to create another submission Log in as an instructor, view all submissions and grade the student submission Check when you go down in the grading interface the "View a different attempt" is displayed as a button (instead of a link) 

      We think that the link in assignment feedback that shows a list of other attempts to select from should be an actual button instead of an unstyled link; you can't tell that you're able to interact with the component and it's very easy to overlook. The code is in the mod_assign attempt_history_chooser template here. Simply adding an extra class like "btn-secondary" on the link that wraps the viewadifferentattempt language string is all that's needed.

      To test this you can follow these steps:

      1. Create a test course with an instructor and student
      2. Make an assignment
      3. Set Additional attempts to "Manual" under Submission settings and set Maximum attempts to more than one
      4. Sign in as a test student to create a submission
      5. Sign in as an instructor, view all submissions, grade the student's
      6. See lower down in the grading interface where the link appears

            aya.saad Aya Saad
            ephetteplace Eric Phetteplace
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Mihail Geshoski Mihail Geshoski
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 17 minutes
                2h 17m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.